components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2691393002: Fix auto raw pointer deduction on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/default_search_policy_handler_unittest.cc ('k') | components/subresource_filter/core/common/first_party_origin_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index 7bdebd6b631fb731dfafa41b48035abd609732ff..231c7aef89b188ee5bcf78a5d9daea94192f204d 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -733,7 +733,7 @@ TEST_P(ContentSubresourceFilterDriverFactoryActivationScopeTest,

"chrome-extension://some-extension", "file:///var/www/index.html"};

const char* supported_urls[] = {"http://example.test",

"https://example.test"};

- for (const auto url : unsupported_urls) {

+ for (auto* url : unsupported_urls) {

SCOPED_TRACE(url);

RedirectChainMatchPattern expected_pattern = EMPTY;

NavigateAndExpectActivation(

@@ -742,7 +742,7 @@ TEST_P(ContentSubresourceFilterDriverFactoryActivationScopeTest,

? ActivationDecision::ACTIVATION_DISABLED

: ActivationDecision::UNSUPPORTED_SCHEME);

}

- for (const auto url : supported_urls) {

+ for (auto* url : supported_urls) {

SCOPED_TRACE(url);

RedirectChainMatchPattern expected_pattern =

test_data.url_matches_activation_list ? NO_REDIRECTS_HIT : EMPTY;