Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2675943003: Remove custom left overs from object grouping (Closed)

Created:
3 years, 10 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Marcel Hlopko, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove custom left overs from object grouping BUG=chromium:682688 Review-Url: https://codereview.chromium.org/2675943003 Cr-Commit-Position: refs/heads/master@{#448163} Committed: https://chromium.googlesource.com/chromium/src/+/2d54dc83d5083e0494f0f642b5d01cfaff39a3b6

Patch Set 1 #

Patch Set 2 : Rebase (0 changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -113 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SharedPersistent.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/PromiseRejectionEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
Michael Lippautz
ptal if I interpret CS correctly, then this should be the last round of removals
3 years, 10 months ago (2017-02-04 02:34:01 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-04 09:27:13 UTC) #13
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-04 18:12:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675943003/20001
3 years, 10 months ago (2017-02-04 22:11:41 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-05 00:12:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675943003/20001
3 years, 10 months ago (2017-02-05 01:38:15 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 02:00:05 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d54dc83d5083e0494f0f642b5d0...

Powered by Google App Engine
This is Rietveld 408576698