third_party/WebKit/Source/bindings/core/v8/ScriptValue.h - Issue 2675943003: Remove custom left overs from object grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

Issue 2675943003: Remove custom left overs from object grouping (Closed)

Patch Set: Rebase (0 changes) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

index 58114d0fd0d8e5de59c4269697c2a05af9d0b69f..91ef8cbb06c25bf1a4881e87cef1ff784113140c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

@@ -164,11 +164,6 @@ class CORE_EXPORT ScriptValue final {

bool toString(String&) const;

- void setReference(const v8::Persistent<v8::Object>& parent,

- v8::Isolate* isolate) {

- m_value->setReference(parent, isolate);

- }

static ScriptValue createNull(ScriptState*);

private: