Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

Issue 2675943003: Remove custom left overs from object grouping (Closed)
Patch Set: Rebase (0 changes) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp
index 33ec9d0d358c2e9aaa73dd5f05324ccc13f94d82..e97a6f146742d6603efae4b4c162969985ed4024 100644
--- a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp
+++ b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp
@@ -51,19 +51,6 @@ ScriptValue PromiseRejectionEvent::reason(ScriptState* scriptState) const {
return ScriptValue(scriptState, m_reason.newLocal(scriptState->isolate()));
}
-void PromiseRejectionEvent::setWrapperReference(
- v8::Isolate* isolate,
- const v8::Persistent<v8::Object>& wrapper) {
- // This might create cross world references. However, the regular code path
- // will not create them, and if we get a cross world reference here, the
- // worst thing is that the lifetime is too long (similar to what happens
- // for DOM trees).
- if (!m_promise.isEmpty())
- m_promise.setReference(wrapper, isolate);
- if (!m_reason.isEmpty())
- m_reason.setReference(wrapper, isolate);
-}
-
const AtomicString& PromiseRejectionEvent::interfaceName() const {
return EventNames::PromiseRejectionEvent;
}

Powered by Google App Engine
This is Rietveld 408576698