third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp - Issue 2675943003: Remove custom left overs from object grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

Issue 2675943003: Remove custom left overs from object grouping (Closed)

Patch Set: Rebase (0 changes) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

index c3e8deacc3036225d608e15d9f320864826865fa..af8bf56239c35b0286cac7181948c3e2d42023c5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

@@ -58,8 +58,7 @@ void V8PerformanceObserver::constructorCustom(

currentExecutionContext(info.GetIsolate()), performance, callback);

// TODO(bashi): Don't set private property (and remove this custom

- // constructor) when we can call setWrapperReference() correctly.

- // crbug.com/468240.

+ // constructor) when we can trace correctly. See crbug.com/468240.

V8PrivateProperty::getPerformanceObserverCallback(info.GetIsolate())

.set(info.GetIsolate()->GetCurrentContext(), wrapper, v8Callback);

v8SetReturnValue(info,