Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h

Issue 2675943003: Remove custom left overs from object grouping (Closed)
Patch Set: Rebase (0 changes) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
index 58f18ee304c4d8524780ffd958297222f4bfcf90..318faa232f773c385ebdd36b988bf441c0492047 100644
--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
@@ -89,12 +89,6 @@ class MODULES_EXPORT RemotePlayback final
void promptCancelled() override;
bool remotePlaybackAvailable() const override;
- // Prevent v8 from garbage collecting the availability callbacks.
- // TODO(avayvod): remove when crbug.com/468240 is fixed and the references
- // are maintained automatically.
- void setV8ReferencesForCallbacks(v8::Isolate*,
- const v8::Persistent<v8::Object>& wrapper);
-
WebRemotePlaybackState m_state;
WebRemotePlaybackAvailability m_availability;
HeapHashMap<int, TraceWrapperMember<RemotePlaybackAvailabilityCallback>>

Powered by Google App Engine
This is Rietveld 408576698