Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

Issue 2675943003: Remove custom left overs from object grouping (Closed)
Patch Set: Rebase (0 changes) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 bool isEmpty() const { return m_handle.IsEmpty(); } 80 bool isEmpty() const { return m_handle.IsEmpty(); }
81 bool isWeak() const { return m_handle.IsWeak(); } 81 bool isWeak() const { return m_handle.IsWeak(); }
82 82
83 virtual void set(v8::Isolate* isolate, v8::Local<T> handle) { 83 virtual void set(v8::Isolate* isolate, v8::Local<T> handle) {
84 m_handle.Reset(isolate, handle); 84 m_handle.Reset(isolate, handle);
85 } 85 }
86 86
87 // Note: This is clear in the std::unique_ptr sense, not the v8::Handle sense. 87 // Note: This is clear in the std::unique_ptr sense, not the v8::Handle sense.
88 void clear() { m_handle.Reset(); } 88 void clear() { m_handle.Reset(); }
89 89
90 void setReference(const v8::Persistent<v8::Object>& parent,
91 v8::Isolate* isolate) {
92 isolate->SetReference(parent, m_handle);
93 }
94
95 bool operator==(const ScopedPersistent<T>& other) { 90 bool operator==(const ScopedPersistent<T>& other) {
96 return m_handle == other.m_handle; 91 return m_handle == other.m_handle;
97 } 92 }
98 93
99 template <class S> 94 template <class S>
100 bool operator==(const v8::Local<S> other) const { 95 bool operator==(const v8::Local<S> other) const {
101 return m_handle == other; 96 return m_handle == other;
102 } 97 }
103 98
104 ALWAYS_INLINE v8::Persistent<T>& get() { return m_handle; } 99 ALWAYS_INLINE v8::Persistent<T>& get() { return m_handle; }
105 100
106 private: 101 private:
107 v8::Persistent<T> m_handle; 102 v8::Persistent<T> m_handle;
108 }; 103 };
109 104
110 } // namespace blink 105 } // namespace blink
111 106
112 #endif // ScopedPersistent_h 107 #endif // ScopedPersistent_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698