third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h - Issue 2675943003: Remove custom left overs from object grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h

Issue 2675943003: Remove custom left overs from object grouping (Closed)

Patch Set: Rebase (0 changes) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SharedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h

index 2682234139eb4419da69eee544aa5de26bec1748..206580d51dcc1206909c5a07f2b79fa99c9b70b0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h

+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h

@@ -54,11 +54,6 @@ class TraceWrapperV8Reference {

void clear() { m_handle.Reset(); }

ALWAYS_INLINE v8::Persistent<T>& get() { return m_handle; }

- void setReference(const v8::Persistent<v8::Object>& parent,

- v8::Isolate* isolate) {

- isolate->SetReference(parent, m_handle);

- }

template <typename S>

const TraceWrapperV8Reference<S>& cast() const {

return reinterpret_cast<const TraceWrapperV8Reference<S>&>(