third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl - Issue 2675943003: Remove custom left overs from object grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2675943003: Remove custom left overs from object grouping (Closed)

Patch Set: Rebase (0 changes) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

index 133cfa1a53548c0e1b106792068d867b51404a4f..8a16e16dde0a9a36542222b9bc0ebf4c0dc5db22 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

@@ -31,11 +31,6 @@ class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_c

return m_callback.newLocal(isolate);

}

- void setWrapperReference(v8::Isolate* isolate, const v8::Persistent<v8::Object>& wrapper) {

- DCHECK(!m_callback.isEmpty());

- m_callback.setReference(wrapper, isolate);

- }

private:

{{cpp_class}}(ScriptState*, v8::Local<v8::Function>);