Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2661353002: ui/gfx: split out code that depends on paint (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
CC:
bruthig+ink_drop_chromium.org, chromium-reviews, dcheng, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, msw+watch_chromium.org, rouslan+bubble_chromium.org, rsesek+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: split out code that depends on paint ios depends on skia and ui/gfx but includes a limited set of functionality from skia. This is handled by deliberately not including paint related files for ios builds. This splits skia_util.* into a separate skia_paint_util.* files that ios can not include, and also disincludes a few additional files that shouldn't be included. This is to make it possible to include a future cc/paint into these files without breaking ios's ban on including anything from cc. See: https://codereview.chromium.org/2640983002 Review-Url: https://codereview.chromium.org/2661353002 Cr-Commit-Position: refs/heads/master@{#447362} Committed: https://chromium.googlesource.com/chromium/src/+/eb8c638a3b2484247195e92df12200069572138e

Patch Set 1 #

Patch Set 2 : Fix mac, chromeos build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -230 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 3 chunks +9 lines, -9 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/shadow_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/gfx/skia_paint_util.h View 2 chunks +5 lines, -51 lines 0 comments Download
A ui/gfx/skia_paint_util.cc View 1 chunk +136 lines, -0 lines 0 comments Download
M ui/gfx/skia_util.h View 2 chunks +1 line, -43 lines 0 comments Download
M ui/gfx/skia_util.cc View 2 chunks +0 lines, -123 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/shadow_border.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
enne (OOO)
3 years, 10 months ago (2017-01-31 20:22:29 UTC) #2
enne (OOO)
I rebased this on top of the rename paint data structures patch, and verified that ...
3 years, 10 months ago (2017-01-31 20:27:46 UTC) #5
danakj
Good idea IMO LGTM
3 years, 10 months ago (2017-01-31 20:33:02 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-01-31 21:38:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661353002/20001
3 years, 10 months ago (2017-01-31 22:36:12 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/eb8c638a3b2484247195e92df12200069572138e
3 years, 10 months ago (2017-01-31 23:30:40 UTC) #18
rohitrao (ping after 24h)
Post-commit lgtm!
3 years, 10 months ago (2017-02-01 00:00:40 UTC) #19
sdefresne
3 years, 10 months ago (2017-02-01 12:39:54 UTC) #21
Message was sent while issue was closed.
Thank you! lgtm

Powered by Google App Engine
This is Rietveld 408576698