Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: ui/gfx/skia_util.cc

Issue 2661353002: ui/gfx: split out code that depends on paint (Closed)
Patch Set: Fix mac, chromeos build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/skia_util.h ('k') | ui/native_theme/native_theme_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/skia_util.cc
diff --git a/ui/gfx/skia_util.cc b/ui/gfx/skia_util.cc
index 963e081369a7d8b068dbd46f2a1671bac7ba4383..6f7818d9a5b02ab1de42200006be406d4e80d0b7 100644
--- a/ui/gfx/skia_util.cc
+++ b/ui/gfx/skia_util.cc
@@ -10,7 +10,6 @@
#include "base/numerics/safe_conversions.h"
#include "base/numerics/safe_math.h"
#include "third_party/skia/include/core/SkBitmap.h"
-#include "third_party/skia/include/core/SkColorFilter.h"
#include "third_party/skia/include/core/SkColorPriv.h"
#include "third_party/skia/include/core/SkUnPreMultiply.h"
#include "third_party/skia/include/effects/SkBlurMaskFilter.h"
@@ -104,128 +103,6 @@ void TransformToFlattenedSkMatrix(const gfx::Transform& transform,
flattened->set(8, SkMScalarToScalar(transform.matrix().get(3, 3)));
}
-sk_sp<SkShader> CreateImageRepShader(const gfx::ImageSkiaRep& image_rep,
- SkShader::TileMode tile_mode,
- const SkMatrix& local_matrix) {
- return CreateImageRepShaderForScale(image_rep, tile_mode, local_matrix,
- image_rep.scale());
-}
-
-sk_sp<SkShader> CreateImageRepShaderForScale(
- const gfx::ImageSkiaRep& image_rep,
- SkShader::TileMode tile_mode,
- const SkMatrix& local_matrix,
- SkScalar scale) {
- // Unscale matrix by |scale| such that the bitmap is drawn at the
- // correct density.
- // Convert skew and translation to pixel coordinates.
- // Thus, for |bitmap_scale| = 2:
- // x scale = 2, x translation = 1 DIP,
- // should be converted to
- // x scale = 1, x translation = 2 pixels.
- SkMatrix shader_scale = local_matrix;
- shader_scale.preScale(scale, scale);
- shader_scale.setScaleX(local_matrix.getScaleX() / scale);
- shader_scale.setScaleY(local_matrix.getScaleY() / scale);
-
- return SkShader::MakeBitmapShader(
- image_rep.sk_bitmap(), tile_mode, tile_mode, &shader_scale);
-}
-
-sk_sp<SkShader> CreateGradientShader(int start_point,
- int end_point,
- SkColor start_color,
- SkColor end_color) {
- SkColor grad_colors[2] = { start_color, end_color};
- SkPoint grad_points[2];
- grad_points[0].iset(0, start_point);
- grad_points[1].iset(0, end_point);
-
- return SkGradientShader::MakeLinear(
- grad_points, grad_colors, NULL, 2, SkShader::kClamp_TileMode);
-}
-
-// TODO(estade): remove. Only exists to support legacy CreateShadowDrawLooper.
-static SkScalar DeprecatedRadiusToSigma(double radius) {
- // This captures historically what skia did under the hood. Now skia accepts
- // sigma, not radius, so we perform the conversion.
- return radius > 0 ? SkDoubleToScalar(0.57735f * radius + 0.5) : 0;
-}
-
-// This is copied from
-// third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h
-static SkScalar RadiusToSigma(double radius) {
- return radius > 0 ? SkDoubleToScalar(0.288675f * radius + 0.5f) : 0;
-}
-
-sk_sp<SkDrawLooper> CreateShadowDrawLooper(
- const std::vector<ShadowValue>& shadows) {
- if (shadows.empty())
- return nullptr;
-
- SkLayerDrawLooper::Builder looper_builder;
-
- looper_builder.addLayer(); // top layer of the original.
-
- SkLayerDrawLooper::LayerInfo layer_info;
- layer_info.fPaintBits |= SkLayerDrawLooper::kMaskFilter_Bit;
- layer_info.fPaintBits |= SkLayerDrawLooper::kColorFilter_Bit;
- layer_info.fColorMode = SkBlendMode::kSrc;
-
- for (size_t i = 0; i < shadows.size(); ++i) {
- const ShadowValue& shadow = shadows[i];
-
- layer_info.fOffset.set(SkIntToScalar(shadow.x()),
- SkIntToScalar(shadow.y()));
-
- SkPaint* paint = looper_builder.addLayer(layer_info);
- // SkBlurMaskFilter's blur radius defines the range to extend the blur from
- // original mask, which is half of blur amount as defined in ShadowValue.
- // Note that because this function uses DeprecatedRadiusToSigma, it actually
- // creates a draw looper with roughly twice the desired blur.
- paint->setMaskFilter(SkBlurMaskFilter::Make(
- kNormal_SkBlurStyle, DeprecatedRadiusToSigma(shadow.blur() / 2),
- SkBlurMaskFilter::kHighQuality_BlurFlag));
- paint->setColorFilter(
- SkColorFilter::MakeModeFilter(shadow.color(), SkBlendMode::kSrcIn));
- }
-
- return looper_builder.detach();
-}
-
-sk_sp<SkDrawLooper> CreateShadowDrawLooperCorrectBlur(
- const std::vector<ShadowValue>& shadows) {
- if (shadows.empty())
- return nullptr;
-
- SkLayerDrawLooper::Builder looper_builder;
-
- looper_builder.addLayer(); // top layer of the original.
-
- SkLayerDrawLooper::LayerInfo layer_info;
- layer_info.fPaintBits |= SkLayerDrawLooper::kMaskFilter_Bit;
- layer_info.fPaintBits |= SkLayerDrawLooper::kColorFilter_Bit;
- layer_info.fColorMode = SkBlendMode::kSrc;
-
- for (size_t i = 0; i < shadows.size(); ++i) {
- const ShadowValue& shadow = shadows[i];
-
- layer_info.fOffset.set(SkIntToScalar(shadow.x()),
- SkIntToScalar(shadow.y()));
-
- SkPaint* paint = looper_builder.addLayer(layer_info);
- // SkBlurMaskFilter's blur radius defines the range to extend the blur from
- // original mask, which is half of blur amount as defined in ShadowValue.
- paint->setMaskFilter(SkBlurMaskFilter::Make(
- kNormal_SkBlurStyle, RadiusToSigma(shadow.blur() / 2),
- SkBlurMaskFilter::kHighQuality_BlurFlag));
- paint->setColorFilter(
- SkColorFilter::MakeModeFilter(shadow.color(), SkBlendMode::kSrcIn));
- }
-
- return looper_builder.detach();
-}
-
bool BitmapsAreEqual(const SkBitmap& bitmap1, const SkBitmap& bitmap2) {
void* addr1 = NULL;
void* addr2 = NULL;
« no previous file with comments | « ui/gfx/skia_util.h ('k') | ui/native_theme/native_theme_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698