Make EarlGrey matchers compliant with Chromium style.

Make EarlGrey matchers compliant with Chromium style.

EarlGrey matchers are C-style, but they start with a lowercase
letter. Our custom matchers started lowercase, so this CL
brings our custom matchers in compliance with Chromium style, while
making it inconsistent with EarlGrey.

BUG=680787
Review-Url: https://codereview.chromium.org/2642193012
Cr-Commit-Position: refs/heads/master@{#445867}
Committed: https://chromium.googlesource.com/chromium/src/+/68f208ca4c5dc605c04bd468746e00cb66140849

[baxley, 2017-01-23 16:46:17]

baxley@chromium.org changed reviewers:
+ eugenebut@google.com

[baxley, 2017-01-23 16:46:18]

I tried to focus this on only fixing the style of our custom matchers. I came
across a few minor issues, but I didn't want to mix them in this CL, I took
notes of some and can address them separately.

Feel free to add comments (or not :) ) on other things that may need cleanup,
which I will handle in other CLs.

I only did matchers in this CL. We have a few other lowercase items (custom
actions), which I will handle separately.

[Eugene But (OOO till 7-30), 2017-01-23 19:39:01]

eugenebut@chromium.org changed reviewers:
+ eugenebut@chromium.org
- eugenebut@google.com

[Eugene But (OOO till 7-30), 2017-01-23 19:39:04]

lgtm

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:56: id<GREYMatcher>
OpenLinkInNewTabButton() {
Could you please add TODO(crbug.com/638674) to clean up this code duplication.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm:209:
WebViewBelongingToWebController()]
Please use WebViewInWebState instead. WebViewBelongingToWebController should
have never been created.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
File
ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm:71:
WebViewBelongingToWebController()]
Please use WebViewInWebState instead.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:274:
chrome_test_util::WebViewContainingText(std::string(""));
nit: std::string()

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/error_page_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/error_page_egtest.mm:22: using
chrome_test_util::WebViewBelongingToWebController;
Please use WebViewInWebState instead.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm:32: using
chrome_test_util::ButtonWithAccessibilityLabel;
Is this used?

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
File ios/chrome/browser/ui/history/history_ui_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
ios/chrome/browser/ui/history/history_ui_egtest.mm:50: id<GREYMatcher>
HistoryEntryWithURL(const GURL& url) {
nit: Since you touching this s/HistoryEntryWithURL/HistoryEntryWithUrl to be
consistent with the rest of the code

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
File
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:52:
id<GREYMatcher> TitleOfTestPageMatcher() {
Do you want to drop matcher suffix for consistency?

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:59:
id<GREYMatcher> BackButtonMatcher() {
Could you please use existing matcher from chrome_matchers instead.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
File ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm:119: void
TapButton(id<GREYMatcher> button) {
Do you want to file a bug to get rid of these methods? Other tests do not use
this pattern.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
File ios/chrome/browser/ui/reading_list/reading_list_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:59: void
AssertButtonNotVisibleWithID(int button_id) {
Do you want to file a bug to get rid of these methods?

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:71: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
Could you please use existing matcher from chrome_matchers instead.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
File ios/chrome/browser/ui/webui/web_ui_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:40: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
Could you please use existing matcher from chrome_matchers instead.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:45: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_FORWARD);
ditto

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:51: id<GREYMatcher>
WaitForOmniboxText(std::string text) {
This name does not look like a matcher name.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/forms_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/forms_egtest.mm:153:
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
Could you please use existing matcher from chrome_matchers?

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/js_print_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/js_print_egtest.mm:15: using
chrome_test_util::WebViewContainingText;
Do you need this?

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm:35:
id<GREYMatcher> ForwardButton() {
Could you please use existing matchers from chrome_matchers.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_matchers.h (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.h:31: id<GREYMatcher>
WebViewBelongingToWebController();
Please remove this instead of fixing it's name.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.h:78: BOOL isOn);
Could you please file a bug to replace BOOL param with something else. In places
where this method is called it's totally unclear what YES/NO mean.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_matchers.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.mm:56: id<GREYMatcher>
WebViewWithNavDelegateOfClass(Class cls) {
Could you please file a bug to remove this method. Making assumption that we use
WKWebView is quite bad.

[baxley, 2017-01-24 22:17:52]

On 2017/01/23 19:39:04, Eugene But wrote:
> lgtm
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
> File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
> ios/chrome/browser/context_menu/context_menu_egtest.mm:56: id<GREYMatcher>
> OpenLinkInNewTabButton() {
> Could you please add TODO(crbug.com/638674) to clean up this code duplication.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
> File ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
> ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm:209:
> WebViewBelongingToWebController()]
> Please use WebViewInWebState instead. WebViewBelongingToWebController should
> have never been created.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
> File
> ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
> (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
>
ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm:71:
> WebViewBelongingToWebController()]
> Please use WebViewInWebState instead.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
> File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
> ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:274:
> chrome_test_util::WebViewContainingText(std::string(""));
> nit: std::string()
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
> File ios/chrome/browser/ui/error_page_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
> ios/chrome/browser/ui/error_page_egtest.mm:22: using
> chrome_test_util::WebViewBelongingToWebController;
> Please use WebViewInWebState instead.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
> File ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
> ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm:32: using
> chrome_test_util::ButtonWithAccessibilityLabel;
> Is this used?
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
> File ios/chrome/browser/ui/history/history_ui_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
> ios/chrome/browser/ui/history/history_ui_egtest.mm:50: id<GREYMatcher>
> HistoryEntryWithURL(const GURL& url) {
> nit: Since you touching this s/HistoryEntryWithURL/HistoryEntryWithUrl to be
> consistent with the rest of the code
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
> File
> ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
> (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
>
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:52:
> id<GREYMatcher> TitleOfTestPageMatcher() {
> Do you want to drop matcher suffix for consistency?
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
>
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:59:
> id<GREYMatcher> BackButtonMatcher() {
> Could you please use existing matcher from chrome_matchers instead.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
> File ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
> (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
> ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm:119:
void
> TapButton(id<GREYMatcher> button) {
> Do you want to file a bug to get rid of these methods? Other tests do not use
> this pattern.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
> File ios/chrome/browser/ui/reading_list/reading_list_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
> ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:59: void
> AssertButtonNotVisibleWithID(int button_id) {
> Do you want to file a bug to get rid of these methods?
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
> File ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
> ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:71: return
> chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
> Could you please use existing matcher from chrome_matchers instead.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
> File ios/chrome/browser/ui/webui/web_ui_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
> ios/chrome/browser/ui/webui/web_ui_egtest.mm:40: return
> chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
> Could you please use existing matcher from chrome_matchers instead.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
> ios/chrome/browser/ui/webui/web_ui_egtest.mm:45: return
> chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_FORWARD);
> ditto
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
> ios/chrome/browser/ui/webui/web_ui_egtest.mm:51: id<GREYMatcher>
> WaitForOmniboxText(std::string text) {
> This name does not look like a matcher name.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> File ios/chrome/browser/web/forms_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> ios/chrome/browser/web/forms_egtest.mm:153:
> chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
> Could you please use existing matcher from chrome_matchers?
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> File ios/chrome/browser/web/js_print_egtest.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> ios/chrome/browser/web/js_print_egtest.mm:15: using
> chrome_test_util::WebViewContainingText;
> Do you need this?
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> File ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm
(right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
> ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm:35:
> id<GREYMatcher> ForwardButton() {
> Could you please use existing matchers from chrome_matchers.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
> File ios/chrome/test/earl_grey/chrome_matchers.h (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
> ios/chrome/test/earl_grey/chrome_matchers.h:31: id<GREYMatcher>
> WebViewBelongingToWebController();
> Please remove this instead of fixing it's name.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
> ios/chrome/test/earl_grey/chrome_matchers.h:78: BOOL isOn);
> Could you please file a bug to replace BOOL param with something else. In
places
> where this method is called it's totally unclear what YES/NO mean.
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
> File ios/chrome/test/earl_grey/chrome_matchers.mm (right):
> 
>
https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
> ios/chrome/test/earl_grey/chrome_matchers.mm:56: id<GREYMatcher>
> WebViewWithNavDelegateOfClass(Class cls) {
> Could you please file a bug to remove this method. Making assumption that we
use
> WKWebView is quite bad.

Comments addressed. I either fixed the issues you pointed out, or filed a bug
(with a TODO and/or responded to the comment with it).

Thanks for the thorough review!

[baxley, 2017-01-24 22:18:50]

Now publishing my comments... (all fixed or bugs filed to address)

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:56: id<GREYMatcher>
OpenLinkInNewTabButton() {
On 2017/01/23 19:39:03, Eugene But wrote:
> Could you please add TODO(crbug.com/638674) to clean up this code duplication.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm:209:
WebViewBelongingToWebController()]
On 2017/01/23 19:39:03, Eugene But wrote:
> Please use WebViewInWebState instead. WebViewBelongingToWebController should
> have never been created.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
File
ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm:71:
WebViewBelongingToWebController()]
On 2017/01/23 19:39:03, Eugene But wrote:
> Please use WebViewInWebState instead.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/d...
ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:274:
chrome_test_util::WebViewContainingText(std::string(""));
On 2017/01/23 19:39:03, Eugene But wrote:
> nit: std::string()

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/error_page_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/error_page_egtest.mm:22: using
chrome_test_util::WebViewBelongingToWebController;
On 2017/01/23 19:39:03, Eugene But wrote:
> Please use WebViewInWebState instead.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm:32: using
chrome_test_util::ButtonWithAccessibilityLabel;
On 2017/01/23 19:39:03, Eugene But wrote:
> Is this used?

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
File ios/chrome/browser/ui/history/history_ui_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/h...
ios/chrome/browser/ui/history/history_ui_egtest.mm:50: id<GREYMatcher>
HistoryEntryWithURL(const GURL& url) {
On 2017/01/23 19:39:03, Eugene But wrote:
> nit: Since you touching this s/HistoryEntryWithURL/HistoryEntryWithUrl to be
> consistent with the rest of the code

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
File
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:52:
id<GREYMatcher> TitleOfTestPageMatcher() {
On 2017/01/23 19:39:03, Eugene But wrote:
> Do you want to drop matcher suffix for consistency? 

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:59:
id<GREYMatcher> BackButtonMatcher() {
On 2017/01/23 19:39:03, Eugene But wrote:
> Could you please use existing matcher from chrome_matchers instead.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
File ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
(right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/q...
ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm:119: void
TapButton(id<GREYMatcher> button) {
On 2017/01/23 19:39:03, Eugene But wrote:
> Do you want to file a bug to get rid of these methods? Other tests do not use
> this pattern.

Thanks for noticing. Filed crbug.com/684099

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
File ios/chrome/browser/ui/reading_list/reading_list_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:59: void
AssertButtonNotVisibleWithID(int button_id) {
On 2017/01/23 19:39:03, Eugene But wrote:
> Do you want to file a bug to get rid of these methods?

Filed a bug. I'll include it in updating the design doc and decide how much we
hate this pattern. crbug.com/684104

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:71: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please use existing matcher from chrome_matchers instead.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
File ios/chrome/browser/ui/webui/web_ui_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:40: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please use existing matcher from chrome_matchers instead.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:45: return
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_FORWARD);
On 2017/01/23 19:39:04, Eugene But wrote:
> ditto

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/web_ui_egtest.mm:51: id<GREYMatcher>
WaitForOmniboxText(std::string text) {
On 2017/01/23 19:39:04, Eugene But wrote:
> This name does not look like a matcher name.

Agreed. I filed crbug.com/684803

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/forms_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/forms_egtest.mm:153:
chrome_test_util::ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please use existing matcher from chrome_matchers?

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/js_print_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/js_print_egtest.mm:15: using
chrome_test_util::WebViewContainingText;
On 2017/01/23 19:39:04, Eugene But wrote:
> Do you need this?

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm:35:
id<GREYMatcher> ForwardButton() {
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please use existing matchers from chrome_matchers.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_matchers.h (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.h:31: id<GREYMatcher>
WebViewBelongingToWebController();
On 2017/01/23 19:39:04, Eugene But wrote:
> Please remove this instead of fixing it's name.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.h:78: BOOL isOn);
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please file a bug to replace BOOL param with something else. In
places
> where this method is called it's totally unclear what YES/NO mean.

Done.

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_matchers.mm (right):

https://codereview.chromium.org/2642193012/diff/40001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_matchers.mm:56: id<GREYMatcher>
WebViewWithNavDelegateOfClass(Class cls) {
On 2017/01/23 19:39:04, Eugene But wrote:
> Could you please file a bug to remove this method. Making assumption that we
use
> WKWebView is quite bad.

Done.

[baxley, 2017-01-24 22:18:59]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-01-24 22:19:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2642193012/#ps100001
(title: "build.gn and rebase")

[commit-bot: I haz the power, 2017-01-24 22:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:58:19]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485296339822480,
"parent_rev": "2fc1646fa5e8434223f2bce7b977fdbb7e2904b6", "commit_rev":
"68f208ca4c5dc605c04bd468746e00cb66140849"}

[commit-bot: I haz the power, 2017-01-24 23:58:54]

Description was changed from

==========
Make EarlGrey matchers compliant with Chromium style.

EarlGrey matchers are C-style, but they start with a lowercase
letter. Our custom matchers started lowercase, so this CL
brings our custom matchers in compliance with Chromium style, while
making it inconsistent with EarlGrey.

BUG=680787
==========

to

==========
Make EarlGrey matchers compliant with Chromium style.

EarlGrey matchers are C-style, but they start with a lowercase
letter. Our custom matchers started lowercase, so this CL
brings our custom matchers in compliance with Chromium style, while
making it inconsistent with EarlGrey.

BUG=680787

Review-Url: https://codereview.chromium.org/2642193012
Cr-Commit-Position: refs/heads/master@{#445867}
Committed:
https://chromium.googlesource.com/chromium/src/+/68f208ca4c5dc605c04bd468746e...
==========

[commit-bot: I haz the power, 2017-01-24 23:58:56]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/68f208ca4c5dc605c04bd468746e...