Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: ios/chrome/browser/ui/browser_view_controller_egtest.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)
Patch Set: build.gn and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller_egtest.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller_egtest.mm b/ios/chrome/browser/ui/browser_view_controller_egtest.mm
index 52f280c61b673095533a8fc594a75b73b5088a56..f5e27cc7f3df3d7c215f7ea1d4e0356661004de0 100644
--- a/ios/chrome/browser/ui/browser_view_controller_egtest.mm
+++ b/ios/chrome/browser/ui/browser_view_controller_egtest.mm
@@ -50,25 +50,25 @@
// Waits for the page to load and check it is the expected content.
id<GREYMatcher> responseMatcher =
- chrome_test_util::webViewContainingText(responses[startURL]);
+ chrome_test_util::WebViewContainingText(responses[startURL]);
[[EarlGrey selectElementWithMatcher:responseMatcher]
assertWithMatcher:grey_notNil()];
// In the omnibox, the URL should be present, without the http:// prefix.
- [[EarlGrey selectElementWithMatcher:chrome_test_util::omnibox()]
- assertWithMatcher:chrome_test_util::omniboxText(startURL.GetContent())];
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
+ assertWithMatcher:chrome_test_util::OmniboxText(startURL.GetContent())];
// Types some javascript in the omnibox to trigger a navigation.
NSString* script =
[NSString stringWithFormat:@"javascript:location.href='%s'\n",
destinationURL.spec().c_str()];
- [[EarlGrey selectElementWithMatcher:chrome_test_util::omnibox()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
performAction:grey_typeText(script)];
// In the omnibox, the new URL should be present, without the http:// prefix.
- [[EarlGrey selectElementWithMatcher:chrome_test_util::omnibox()]
- assertWithMatcher:chrome_test_util::omniboxText(
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
+ assertWithMatcher:chrome_test_util::OmniboxText(
destinationURL.GetContent())];
// Verifies that the navigation to the destination page happened.
@@ -78,7 +78,7 @@
// Verifies that the destination page is shown.
id<GREYMatcher> navigationMatcher =
- chrome_test_util::webViewContainingText(responses[destinationURL]);
+ chrome_test_util::WebViewContainingText(responses[destinationURL]);
[[EarlGrey selectElementWithMatcher:grey_kindOfClass([WKWebView class])]
assertWithMatcher:navigationMatcher];
}
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm ('k') | ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698