Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)
Patch Set: build.gn and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web/window_open_by_dom_egtest.mm ('k') | ios/chrome/test/earl_grey/chrome_matchers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
diff --git a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
index eff0c5ac48a9fb256dfc8817ece7d78649037202..7cfc95197435d42c64932bc6a4f0955b727495c9 100644
--- a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
+++ b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
@@ -22,10 +22,10 @@ using testing::kWaitForPageLoadTimeout;
// TODO(crbug.com/639524): Add logic to ensure the app is in the correct
// state, for example DCHECK if no tabs are displayed.
[[[EarlGrey
- selectElementWithMatcher:grey_allOf(chrome_test_util::toolsMenuButton(),
+ selectElementWithMatcher:grey_allOf(chrome_test_util::ToolsMenuButton(),
grey_sufficientlyVisible(), nil)]
usingSearchAction:grey_swipeSlowInDirection(kGREYDirectionDown)
- onElementWithMatcher:web::webViewScrollView(
+ onElementWithMatcher:web::WebViewScrollView(
chrome_test_util::GetCurrentWebState())]
performAction:grey_tap()];
// TODO(crbug.com/639517): Add webViewScrollView matcher so we don't have
@@ -55,7 +55,7 @@ using testing::kWaitForPageLoadTimeout;
if (IsCompact()) {
[self openToolsMenu];
}
- [[EarlGrey selectElementWithMatcher:chrome_test_util::reloadButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::ReloadButton()]
performAction:grey_tap()];
}
@@ -63,7 +63,7 @@ using testing::kWaitForPageLoadTimeout;
if (IsCompact()) {
[ChromeEarlGreyUI openToolsMenu];
}
- [[EarlGrey selectElementWithMatcher:chrome_test_util::shareButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::ShareButton()]
performAction:grey_tap()];
}
« no previous file with comments | « ios/chrome/browser/web/window_open_by_dom_egtest.mm ('k') | ios/chrome/test/earl_grey/chrome_matchers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698