Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: ios/chrome/browser/web/window_open_by_dom_egtest.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)
Patch Set: build.gn and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web/visible_url_egtest.mm ('k') | ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/window_open_by_dom_egtest.mm
diff --git a/ios/chrome/browser/web/window_open_by_dom_egtest.mm b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
index 3fa7f1d95accc762c800f497a471f35a83ec737a..6df1cbd2ef48826cc16d1bb0d9e0e9e3290aa31a 100644
--- a/ios/chrome/browser/web/window_open_by_dom_egtest.mm
+++ b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
@@ -17,9 +17,9 @@
#include "ios/web/public/test/http_server_util.h"
using chrome_test_util::AssertMainTabCount;
-using chrome_test_util::omniboxText;
+using chrome_test_util::OmniboxText;
using chrome_test_util::TapWebViewElementWithId;
-using chrome_test_util::webViewContainingText;
+using chrome_test_util::WebViewContainingText;
using web::test::HttpServer;
namespace {
@@ -48,7 +48,7 @@ const char kTestURL[] =
[super setUp];
// Open the test page. There should only be one tab open.
[ChromeEarlGrey loadURL:HttpServer::MakeUrl(kTestURL)];
- [[EarlGrey selectElementWithMatcher:webViewContainingText("Expected result")]
+ [[EarlGrey selectElementWithMatcher:WebViewContainingText("Expected result")]
assertWithMatcher:grey_notNil()];
AssertMainTabCount(1);
}
@@ -92,7 +92,7 @@ const char kTestURL[] =
// Ensure that the resulting tab is updated as expected.
const GURL targetURL =
HttpServer::MakeUrl(std::string(kTestURL) + "#assigned");
- [[EarlGrey selectElementWithMatcher:omniboxText(targetURL.GetContent())]
+ [[EarlGrey selectElementWithMatcher:OmniboxText(targetURL.GetContent())]
assertWithMatcher:grey_notNil()];
}
@@ -106,7 +106,7 @@ const char kTestURL[] =
// Ensure that the resulting tab is updated as expected.
const GURL targetURL =
HttpServer::MakeUrl(std::string(kTestURL) + "#updated");
- [[EarlGrey selectElementWithMatcher:omniboxText(targetURL.GetContent())]
+ [[EarlGrey selectElementWithMatcher:OmniboxText(targetURL.GetContent())]
assertWithMatcher:grey_notNil()];
}
@@ -159,7 +159,7 @@ const char kTestURL[] =
// Ensure that the starting tab hasn't navigated.
chrome_test_util::CloseCurrentTab();
const GURL URL = HttpServer::MakeUrl(kTestURL);
- [[EarlGrey selectElementWithMatcher:omniboxText(URL.GetContent())]
+ [[EarlGrey selectElementWithMatcher:OmniboxText(URL.GetContent())]
assertWithMatcher:grey_notNil()];
}
« no previous file with comments | « ios/chrome/browser/web/visible_url_egtest.mm ('k') | ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698