Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: ios/chrome/browser/web/stop_loading_egtest.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)
Patch Set: build.gn and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/web/stop_loading_egtest.mm
diff --git a/ios/chrome/browser/web/stop_loading_egtest.mm b/ios/chrome/browser/web/stop_loading_egtest.mm
index dfcf468c6197e1d34113ab329a1bc502b977346a..61c832ca6f8cc278541475e51a4fb1565f8987f4 100644
--- a/ios/chrome/browser/web/stop_loading_egtest.mm
+++ b/ios/chrome/browser/web/stop_loading_egtest.mm
@@ -17,8 +17,8 @@
#include "ios/web/public/test/response_providers/html_response_provider.h"
#include "url/gurl.h"
-using chrome_test_util::buttonWithAccessibilityLabelId;
-using chrome_test_util::webViewContainingText;
+using chrome_test_util::ButtonWithAccessibilityLabelId;
+using chrome_test_util::WebViewContainingText;
namespace {
@@ -102,7 +102,7 @@ class InfinitePendingResponseProvider : public HtmlResponseProvider {
}
// Wait until the page is half loaded.
- [[EarlGrey selectElementWithMatcher:webViewContainingText(kPageText)]
+ [[EarlGrey selectElementWithMatcher:WebViewContainingText(kPageText)]
assertWithMatcher:grey_notNil()];
// On iPhone Stop/Reload button is a part of tools menu, so open it.
@@ -111,13 +111,13 @@ class InfinitePendingResponseProvider : public HtmlResponseProvider {
}
// Verify that stop button is visible and reload button is hidden.
- [[EarlGrey selectElementWithMatcher:chrome_test_util::stopButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::StopButton()]
assertWithMatcher:grey_sufficientlyVisible()];
- [[EarlGrey selectElementWithMatcher:chrome_test_util::reloadButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::ReloadButton()]
assertWithMatcher:grey_notVisible()];
// Stop the page loading.
- [[EarlGrey selectElementWithMatcher:chrome_test_util::stopButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::StopButton()]
performAction:grey_tap()];
// Enable synchronization back. The spinner should become idle and test should
@@ -130,9 +130,9 @@ class InfinitePendingResponseProvider : public HtmlResponseProvider {
if (!IsIPadIdiom()) {
[ChromeEarlGreyUI openToolsMenu];
}
- [[EarlGrey selectElementWithMatcher:chrome_test_util::stopButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::StopButton()]
assertWithMatcher:grey_notVisible()];
- [[EarlGrey selectElementWithMatcher:chrome_test_util::reloadButton()]
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::ReloadButton()]
assertWithMatcher:grey_sufficientlyVisible()];
}
« no previous file with comments | « ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm ('k') | ios/chrome/browser/web/visible_url_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698