ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm - Issue 2642193012: Make EarlGrey matchers compliant with Chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)

Patch Set: build.gn and rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

diff --git a/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm b/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

index dce6d1419d079ba12a11b14f9248627fcbb696c6..b0eb91fdda869f8ac5ce9e7998264c3581cac08d 100644

--- a/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

+++ b/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

@@ -29,8 +29,7 @@ const std::string kFindInPageResponse = "Find in page. Find in page.";

} // namespace

-using chrome_test_util::buttonWithAccessibilityLabel;

-using chrome_test_util::webViewContainingText;

+using chrome_test_util::WebViewContainingText;

// Tests for Find in Page.

@interface FindInPageTestCase : ChromeTestCase

@@ -221,7 +220,7 @@ using chrome_test_util::webViewContainingText;

// Verify web page finished loading.

[[EarlGrey

- selectElementWithMatcher:webViewContainingText(kFindInPageResponse)]

+ selectElementWithMatcher:WebViewContainingText(kFindInPageResponse)]

assertWithMatcher:grey_notNil()];

}