Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Issue 2642193012: Make EarlGrey matchers compliant with Chromium style. (Closed)
Patch Set: build.gn and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
diff --git a/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm b/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
index bcf864acfae335e4178f3b277ff6803bd5b7ab41..9e44e60abfa3eb229170429ab37647bb8eda075b 100644
--- a/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
+++ b/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
@@ -16,8 +16,8 @@
#include "ios/web/public/test/http_server_util.h"
#include "ui/base/l10n/l10n_util.h"
-using chrome_test_util::buttonWithAccessibilityLabel;
-using chrome_test_util::buttonWithAccessibilityLabelId;
+using chrome_test_util::ButtonWithAccessibilityLabel;
+using chrome_test_util::ButtonWithAccessibilityLabelId;
namespace {
@@ -74,7 +74,7 @@ NSString* GetTextFieldForID(int categoryId) {
// of the value being empty is handled gracefully.
void ClearCountryValue() {
// Switch on edit mode.
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabelId(
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
IDS_IOS_NAVIGATION_BAR_EDIT_BUTTON)]
performAction:grey_tap()];
@@ -100,7 +100,7 @@ void ClearCountryValue() {
nil)] performAction:grey_tap()];
// Switch off edit mode.
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabelId(
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)]
performAction:grey_tap()];
}
@@ -134,7 +134,7 @@ void ClearCountryValue() {
selectElementWithMatcher:grey_accessibilityID(kToolsMenuSettingsId)]
performAction:grey_tap()];
NSString* label = l10n_util::GetNSString(IDS_IOS_AUTOFILL);
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabel(label)]
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabel(label)]
performAction:grey_tap()];
// Tap on the 'George Washington' result.
@@ -158,7 +158,7 @@ void ClearCountryValue() {
grey_accessibilityTrait(
UIAccessibilityTraitButton),
nil)] performAction:grey_tap()];
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabelId(
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)]
performAction:grey_tap()];
// Wait for UI components to finish loading.
@@ -195,7 +195,7 @@ void ClearCountryValue() {
ClearCountryValue();
// Switch on edit mode.
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabelId(
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
IDS_IOS_NAVIGATION_BAR_EDIT_BUTTON)]
performAction:grey_tap()];
@@ -205,7 +205,7 @@ void ClearCountryValue() {
performAction:grey_typeText(expectation.user_typed_country)];
// Switch off edit mode.
- [[EarlGrey selectElementWithMatcher:buttonWithAccessibilityLabelId(
+ [[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabelId(
IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)]
performAction:grey_tap()];
« no previous file with comments | « ios/chrome/browser/ui/settings/accounts_collection_egtest.mm ('k') | ios/chrome/browser/ui/settings/block_popups_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698