Make EarlGrey matchers compliant with Chromium style.

ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 38 matching lines @@
           chrome_test_util::GetOriginalBrowserState());
   GREYAssert(testing::WaitUntilConditionOrTimeout(2,
                                                   ^{
                                                     return model->loaded();
                                                   }),
              @"Reading List model did not load");
   return model;
 }
 
 // Asserts the |button_id| button is not visible.
 void AssertButtonNotVisibleWithID(int button_id) {

[Eugene But (OOO till 7-30), 2017/01/23 19:39:03]

Do you want to file a bug to get rid of these methods?

[baxley, 2017/01/24 22:18:49]

Filed a bug. I'll include it in updating the design doc and decide how much we
hate this pattern. crbug.com/684104

   [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::buttonWithAccessibilityLabelId(
+      selectElementWithMatcher:chrome_test_util::ButtonWithAccessibilityLabelId(
                                    button_id)]
       assertWithMatcher:grey_notVisible()];
 }
 
 // Assert the |button_id| button is visible.
 void AssertButtonVisibleWithID(int button_id) {
   [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::buttonWithAccessibilityLabelId(
+      selectElementWithMatcher:chrome_test_util::ButtonWithAccessibilityLabelId(
                                    button_id)]
       assertWithMatcher:grey_sufficientlyVisible()];
 }
 
 // Taps the |button_id| button.
 void TapButtonWithID(int button_id) {
   [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::buttonWithAccessibilityLabelId(
+      selectElementWithMatcher:chrome_test_util::ButtonWithAccessibilityLabelId(
                                    button_id)] performAction:grey_tap()];
 }
 
 // Taps the entry |title|.
 void TapEntry(std::string title) {
   [[EarlGrey selectElementWithMatcher:
-                 grey_allOf(chrome_test_util::staticTextWithAccessibilityLabel(
+                 grey_allOf(chrome_test_util::StaticTextWithAccessibilityLabel(
                                 base::SysUTF8ToNSString(title)),
                             grey_sufficientlyVisible(), nil)]
       performAction:grey_tap()];
 }
 
 // Asserts that the entry |title| is visible.
 void AssertEntryVisible(std::string title) {
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   [[EarlGrey
       selectElementWithMatcher:
-          grey_allOf(chrome_test_util::staticTextWithAccessibilityLabel(
+          grey_allOf(chrome_test_util::StaticTextWithAccessibilityLabel(
                          base::SysUTF8ToNSString(title)),
                      grey_ancestor(grey_kindOfClass([ReadingListCell class])),
                      nil)] assertWithMatcher:grey_sufficientlyVisible()];
 }
 
 // Asserts that all the entries are visible.
 void AssertAllEntriesVisible() {
   AssertEntryVisible(kReadTitle);
   AssertEntryVisible(kReadTitle2);
   AssertEntryVisible(kUnreadTitle);
   AssertEntryVisible(kUnreadTitle2);
 
   // If the number of entries changes, make sure this assert gets updated.
   GREYAssertEqual((size_t)2, kNumberReadEntries,
                   @"The number of entries have changed");
   GREYAssertEqual((size_t)2, kNumberUnreadEntries,
                   @"The number of entries have changed");
 }
 
 // Asserts that the entry |title| is not visible.
 void AssertEntryNotVisible(std::string title) {
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   [[EarlGrey
       selectElementWithMatcher:
-          grey_allOf(chrome_test_util::staticTextWithAccessibilityLabel(
+          grey_allOf(chrome_test_util::StaticTextWithAccessibilityLabel(
                          base::SysUTF8ToNSString(title)),
                      grey_ancestor(grey_kindOfClass([ReadingListCell class])),
                      nil)] assertWithMatcher:grey_notVisible()];
 }
 
 // Asserts |header| is visible.
 void AssertHeaderNotVisible(std::string header) {
   [[EarlGrey selectElementWithMatcher:chrome_test_util::
-                                          staticTextWithAccessibilityLabel(
+                                          StaticTextWithAccessibilityLabel(
                                               base::SysUTF8ToNSString(header))]
       assertWithMatcher:grey_notVisible()];
 }
 
 // Opens the reading list menu using command line.
 void OpenReadingList() {
   base::scoped_nsobject<GenericChromeCommand> command(
       [[GenericChromeCommand alloc] initWithTag:IDC_SHOW_READING_LIST]);
   chrome_test_util::RunCommandWithActiveViewController(command);
 }
@@ skipping 63 matching lines @@
 
   // Open http://potato
   [ChromeEarlGrey loadURL:regularPageURL];
 
   // Add the page to the reading list.
   [ChromeEarlGreyUI openShareMenu];
   TapButtonWithID(IDS_IOS_SHARE_MENU_READING_LIST_ACTION);
 
   // Wait for the snackbar to appear.
   id<GREYMatcher> snackbarMatcher =
-      chrome_test_util::buttonWithAccessibilityLabelId(
+      chrome_test_util::ButtonWithAccessibilityLabelId(
           IDS_IOS_READING_LIST_SNACKBAR_MESSAGE);
   ConditionBlock waitForAppearance = ^{
     NSError* error = nil;
     [[EarlGrey selectElementWithMatcher:snackbarMatcher]
         assertWithMatcher:grey_notNil()
                     error:&error];
     return error == nil;
   };
   // Wait for the snackbar to disappear.
   GREYAssert(testing::WaitUntilConditionOrTimeout(kSnackbarAppearanceTimeout,
@@ skipping 212 matching lines @@
   // Tap the action sheet.
   TapButtonWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
 
   AssertAllEntriesVisible();
   XCTAssertEqual(kNumberReadEntries + 1, ModelReadSize(GetReadingListModel()));
   XCTAssertEqual(kNumberUnreadEntries - 1,
                  GetReadingListModel()->unread_size());
 }
 
 @end