[EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

[EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of only getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
  |CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
  be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789

[chongz, 2017-01-11 20:22:14]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:22:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:40:17]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[chongz, 2017-01-11 22:39:39]

Description was changed from

==========
Pass CommandSource by ctor instead of |apply(source)|

BUG=673789
==========

to

==========
[Editing] Pass command source by |CompositeEditCommand| ctor instead of
|apply(source)|

BUG=673789
==========

[chongz, 2017-01-11 22:40:07]

Description was changed from

==========
[Editing] Pass command source by |CompositeEditCommand| ctor instead of
|apply(source)|

BUG=673789
==========

to

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

BUG=673789
==========

[chongz, 2017-01-11 22:47:17]

Description was changed from

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

BUG=673789
==========

to

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
|CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789
==========

[chongz, 2017-01-11 22:49:31]

Description was changed from

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
|CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789
==========

to

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of only getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
  |CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
  be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789
==========

[chongz, 2017-01-11 23:36:16]

Description was changed from

==========
[Editing] Pass command source through |CompositeEditCommand| ctor instead of
|apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of only getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
  |CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
  be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789
==========

to

==========
[EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of
|apply(source)|

We want to store |EditCommandSource| in |CompositeEditCommand| as an attribute
instead of only getting it from |apply(source)|.

This CL:
1. Change |apply(EditCommandSource)| => |apply()|
2. Add |EditCommandSource::kInternal|
3. Add default parameter |EditCommandSource::kInternal| to
  |CompositeEditCommand|'s ctor
4. Add required parameter |EditCommandSource| to other commands' ctor that might
  be executed from JS

See yosin@'s comments:
https://codereview.chromium.org/2610063008/#msg13

BUG=673789
==========

[chongz, 2017-01-11 23:39:18]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-01-11 23:39:18]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-01-12 04:01:13]

We should start over == reverting following patch first:

- 1dfe560 [InputEvent] Remove unused |inputType()| from |UndoStep| and
|EditCommandComposition| by chongz · 3 weeks ago
- c659648 [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in
prepare for 'beforeinput' (2/3) by chongz · 3 weeks ago
- 4d0f52c [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in
prepare for 'beforeinput' (1/3) by chongz · 3 weeks ago
- acce62c [EditCommandSource] Pass source to |CompositEditCommand| and
|TypingCommand| (3/3) by chongz · 4 weeks ago
- 17c7368 [EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3) by chongz · 4 weeks ago

Then
1. Introduce |enum class EditCommandSouce| and CompoisiteCommand ctor takes it
as default parameter = kInternal.
2. Make ApplyBlockElementCommand aware of EditCommandSource
3. Make ApplyStyleCommand aware of EditCommandSource
4. ...
N. Make UlinkCommand aware of EditCommandSouce
N+1. Implement dispatch "beforeinput" to with EditCommandSource support.

In this way, each patch is *small* and easy to review.

You don't need to wait for review for reverting, just use TBR=yosin@chromium.org
is fine.

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:46:
kMenuOrKeyBinding,  // from menu, or keyboard shortcut
I prefer to use |kUserAction| instead of |kMenuOrKeyBinding|. Because
|kMenuOrKeyBinding| is too specific of user action, in the future, we may
support user gesture, voice, eye tracking, brain reading etc.

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:47: kDOM,
              // document.execCommand()
I prefer to use |kExecCommand|, |kScriptAPI|, or another indicating the command
created as result of |document.execCommand()|.

[chongz, 2017-01-13 16:28:27]

On 2017/01/12 04:01:13, Yosi_UTC9 wrote:
> We should start over == reverting following patch first:
> 
> - 1dfe560 [InputEvent] Remove unused |inputType()| from |UndoStep| and
> |EditCommandComposition| by chongz · 3 weeks ago
> - c659648 [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in
> prepare for 'beforeinput' (2/3) by chongz · 3 weeks ago
> - 4d0f52c [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in
> prepare for 'beforeinput' (1/3) by chongz · 3 weeks ago
> - acce62c [EditCommandSource] Pass source to |CompositEditCommand| and
> |TypingCommand| (3/3) by chongz · 4 weeks ago
> - 17c7368 [EditCommandSource] Rename and move |EditorCommandSource| to
> "CompositeEditCommand.h" (1/3) by chongz · 4 weeks ago
> 
> Then
> 1. Introduce |enum class EditCommandSouce| and CompoisiteCommand ctor takes it
> as default parameter = kInternal.
> 2. Make ApplyBlockElementCommand aware of EditCommandSource
> 3. Make ApplyStyleCommand aware of EditCommandSource
> 4. ...
> N. Make UlinkCommand aware of EditCommandSouce
> N+1. Implement dispatch "beforeinput" to with EditCommandSource support.
> 
> In this way, each patch is *small* and easy to review.
> 
> You don't need to wait for review for reverting, just use
mailto:TBR=yosin@chromium.org
> is fine.
> 
>
https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
> (right):
> 
>
https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:46:
> kMenuOrKeyBinding,  // from menu, or keyboard shortcut
> I prefer to use |kUserAction| instead of |kMenuOrKeyBinding|. Because
> |kMenuOrKeyBinding| is too specific of user action, in the future, we may
> support user gesture, voice, eye tracking, brain reading etc.
> 
>
https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:47:
kDOM,
>               // document.execCommand()
> I prefer to use |kExecCommand|, |kScriptAPI|, or another indicating the
command
> created as result of |document.execCommand()|.

Thanks for the detailed plan! I've re-opened https://crbug.com/673789 and
updated bug description. I'm going to revert the mentioned CLs.

+dtapuska@, +chaopeng@ as an update.

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:46:
kMenuOrKeyBinding,  // from menu, or keyboard shortcut
On 2017/01/12 04:01:13, Yosi_UTC9 wrote:
> I prefer to use |kUserAction| instead of |kMenuOrKeyBinding|. Because
> |kMenuOrKeyBinding| is too specific of user action, in the future, we may
> support user gesture, voice, eye tracking, brain reading etc.

Will do.

https://codereview.chromium.org/2627103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:47: kDOM,
              // document.execCommand()
On 2017/01/12 04:01:13, Yosi_UTC9 wrote:
> I prefer to use |kExecCommand|, |kScriptAPI|, or another indicating the
command
> created as result of |document.execCommand()|.

Will do.