Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
index b31792328b4994e5b4c4257efed91bdb6b4aaad8..6eb70909712e3cbaa4fa89e0535e7e56cd6ce7ec 100644
--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
@@ -47,12 +47,11 @@ TEST_F(DeleteSelectionCommandTest, deleteListFromTable) {
const bool kNoExpandForSpecialElements = false;
const bool kSanitizeMarkup = true;
DeleteSelectionCommand* command = DeleteSelectionCommand::create(
- document(), kNoSmartDelete, kMergeBlocksAfterDelete,
- kNoExpandForSpecialElements, kSanitizeMarkup,
+ document(), EditCommandSource::kMenuOrKeyBinding, kNoSmartDelete,
+ kMergeBlocksAfterDelete, kNoExpandForSpecialElements, kSanitizeMarkup,
InputEvent::InputType::DeleteByCut);
- EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))
- << "the delete command should have succeeded";
+ EXPECT_TRUE(command->apply()) << "the delete command should have succeeded";
EXPECT_EQ("<div contenteditable=\"true\"><br></div>",
document().body()->innerHTML());
EXPECT_TRUE(frame->selection().isCaret());

Powered by Google App Engine
This is Rietveld 408576698