third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index fb353fdb7b7853b4c85314c897247b4e190f174c..0941c93ed08f9f09ed2f7bad68906f8e671478e7 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -43,15 +43,17 @@ using namespace HTMLNames;

ApplyBlockElementCommand::ApplyBlockElementCommand(

Document& document,

+ EditCommandSource source,

const QualifiedName& tagName,

const AtomicString& inlineStyle)

- : CompositeEditCommand(document),

+ : CompositeEditCommand(document, source),

m_tagName(tagName),

m_inlineStyle(inlineStyle) {}

ApplyBlockElementCommand::ApplyBlockElementCommand(Document& document,

+ EditCommandSource source,

const QualifiedName& tagName)

- : CompositeEditCommand(document), m_tagName(tagName) {}

+ : CompositeEditCommand(document, source), m_tagName(tagName) {}

void ApplyBlockElementCommand::doApply(EditingState* editingState) {

if (!endingSelection().rootEditableElement())