Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
index ecc6a3df2097432c17d46c927a6ed7a77490a758..e4f0a33bf70a3e44f0dd75f36adb283f895eee2b 100644
--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
@@ -113,24 +113,27 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {
private:
static TypingCommand* create(
Document& document,
+ EditCommandSource source,
ETypingCommand command,
const String& text = "",
Options options = 0,
TextGranularity granularity = CharacterGranularity) {
- return new TypingCommand(document, command, text, options, granularity,
- TextCompositionNone);
+ return new TypingCommand(document, source, command, text, options,
+ granularity, TextCompositionNone);
}
static TypingCommand* create(Document& document,
+ EditCommandSource source,
ETypingCommand command,
const String& text,
Options options,
TextCompositionType compositionType) {
- return new TypingCommand(document, command, text, options,
+ return new TypingCommand(document, source, command, text, options,
CharacterGranularity, compositionType);
}
TypingCommand(Document&,
+ EditCommandSource,
ETypingCommand,
const String& text,
Options,

Powered by Google App Engine
This is Rietveld 408576698