[EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 24 matching lines @@
 
 namespace blink {
 
 class EditingStyle;
 class Element;
 class HTMLBRElement;
 class HTMLElement;
 class HTMLSpanElement;
 class Text;
 
-enum class EditCommandSource { kMenuOrKeyBinding, kDOM };
+enum class EditCommandSource {
+  kMenuOrKeyBinding,  // from menu, or keyboard shortcut

[yosin_UTC9, 2017/01/12 04:01:13]

I prefer to use |kUserAction| instead of |kMenuOrKeyBinding|. Because
|kMenuOrKeyBinding| is too specific of user action, in the future, we may
support user gesture, voice, eye tracking, brain reading etc.

[chongz, 2017/01/13 16:28:27]

Will do.

+  kDOM,               // document.execCommand()

[yosin_UTC9, 2017/01/12 04:01:13]

I prefer to use |kExecCommand|, |kScriptAPI|, or another indicating the command
created as result of |document.execCommand()|.

[chongz, 2017/01/13 16:28:27]

Will do.

+  kInternal,          // Blink creates a command for implementation.
+};
 
 class EditCommandComposition final : public UndoStep {
  public:
   static EditCommandComposition* create(Document*,
                                         const VisibleSelection&,
                                         const VisibleSelection&);
 
   bool belongsTo(const LocalFrame&) const override;
   void unapply(EditCommandSource) override;
   void reapply(EditCommandSource) override;
@@ skipping 37 matching lines @@
 };
 
 class CORE_EXPORT CompositeEditCommand : public EditCommand {
  public:
   enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
   enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };
 
   ~CompositeEditCommand() override;
 
   // Returns |false| if the command failed.  e.g. It's aborted.
-  bool apply(EditCommandSource);
+  bool apply();
   bool isFirstCommand(EditCommand* command) {
     return !m_commands.isEmpty() && m_commands.front() == command;
   }
   EditCommandComposition* composition() { return m_composition.get(); }
   EditCommandComposition* ensureComposition();
   // Append composition from an already applied command.
   void appendCommandToComposite(CompositeEditCommand*);
 
   virtual bool isReplaceSelectionCommand() const;
   virtual bool isTypingCommand() const;
   virtual bool isCommandGroupWrapper() const;
   virtual bool isDragAndDropCommand() const;
   virtual bool preservesTypingStyle() const;
   virtual void setShouldRetainAutocorrectionIndicator(bool);
   virtual bool shouldStopCaretBlinking() const { return false; }
 
   DECLARE_VIRTUAL_TRACE();
 
  protected:
-  explicit CompositeEditCommand(Document&);
+  explicit CompositeEditCommand(
+      Document&,
+      EditCommandSource = EditCommandSource::kInternal);
 
   // TODO(chongz): Implement "beforeinput" as described below:
   // Fires "beforeinput" and will return |false| to cancel applying editing if
   //   * "beforeinput" was canceled, or
   //   * |frame| was destroyed by event handlers.
   // |willApplyEditing()| should be called from
   //   * |CompositeEditCommand::apply()|, and
   //   * |TypingCommand::willAddTypingToOpenCommand()|.
   bool willApplyEditing(EditCommandSource);
 
@@ skipping 140 matching lines @@
                                                   EditingState*);
 
   Node* splitTreeToNode(Node*, Node*, bool splitAncestor = false);
 
   HeapVector<Member<EditCommand>> m_commands;
 
  private:
   bool isCompositeEditCommand() const final { return true; }
 
   Member<EditCommandComposition> m_composition;
+  EditCommandSource m_source;
 };
 
 DEFINE_TYPE_CASTS(CompositeEditCommand,
                   EditCommand,
                   command,
                   command->isCompositeEditCommand(),
                   command.isCompositeEditCommand());
 
 }  // namespace blink
 
 #endif  // CompositeEditCommand_h