third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h ('K') | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 13c1cbdb9e22ac3f62d0301efcd3138549d45a62..4a95b18ab768b834ff6169fdf85552ea96fea46f 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -438,10 +438,11 @@ inline void ReplaceSelectionCommand::InsertedNodes::didReplaceNode(

ReplaceSelectionCommand::ReplaceSelectionCommand(

Document& document,

+ EditCommandSource source,

DocumentFragment* fragment,

CommandOptions options,

InputEvent::InputType inputType)

- : CompositeEditCommand(document),

+ : CompositeEditCommand(document, source),

m_selectReplacement(options & SelectReplacement),

m_smartReplace(options & SmartReplace),

m_matchStyle(options & MatchStyle),