third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h ('K') | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index 028d0fb5d524f8d4873d2d2c038af0d6c9eab5d6..b5acda2d6e244299fe1f54ce637b1745e4f73349 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -66,13 +66,14 @@ static bool isTableRowEmpty(Node* row) {

DeleteSelectionCommand::DeleteSelectionCommand(

Document& document,

+ EditCommandSource source,

bool smartDelete,

bool mergeBlocksAfterDelete,

bool expandForSpecialElements,

bool sanitizeMarkup,

InputEvent::InputType inputType,

const Position& referenceMovePosition)

- : CompositeEditCommand(document),

+ : CompositeEditCommand(document, source),

m_hasSelectionToDelete(false),

m_smartDelete(smartDelete),

m_mergeBlocksAfterDelete(mergeBlocksAfterDelete),