third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp - Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.h » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp

index 40129f6658de641ac32e9b1738611b20bdbae009..90994b16101af68684280a55f56d96084df0b8e4 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp

@@ -44,9 +44,9 @@ TEST_F(ApplyBlockElementCommandTest, selectionCrossingOverBody) {

Position(document().getElementById("va")->firstChild(), 2))

.build());

- FormatBlockCommand* command =

- FormatBlockCommand::create(document(), HTMLNames::footerTag);

- command->apply(EditCommandSource::kMenuOrKeyBinding);

+ FormatBlockCommand* command = FormatBlockCommand::create(

+ document(), EditCommandSource::kMenuOrKeyBinding, HTMLNames::footerTag);

+ command->apply();

EXPECT_EQ(

"<body contenteditable=\"false\">\n"

@@ -68,9 +68,10 @@ TEST_F(ApplyBlockElementCommandTest, visibilityChangeDuringCommand) {

.collapse(Position(document().querySelector("li"), 0))

.build());

- IndentOutdentCommand* command =

- IndentOutdentCommand::create(document(), IndentOutdentCommand::Indent);

- command->apply(EditCommandSource::kMenuOrKeyBinding);

+ IndentOutdentCommand* command = IndentOutdentCommand::create(

+ document(), EditCommandSource::kMenuOrKeyBinding,

+ IndentOutdentCommand::Indent);

+ command->apply();

EXPECT_EQ(

"<head><style>li:first-child { visibility:visible; }</style></head>"