Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
index bea2af380f1e7e4581027b3db3d25934c613dbca..b2a2ce9b9970bbf963b6cdf89fbfc5c417b40dec 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
@@ -39,10 +39,11 @@ TEST_F(InsertListCommandTest, ShouldCleanlyRemoveSpuriousTextNode) {
.extend(Position(document().body(), 2))
.build());
- InsertListCommand* command =
- InsertListCommand::create(document(), InsertListCommand::OrderedList);
+ InsertListCommand* command = InsertListCommand::create(
+ document(), EditCommandSource::kMenuOrKeyBinding,
+ InsertListCommand::OrderedList);
// This should not DCHECK.
- EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))
+ EXPECT_TRUE(command->apply())
<< "The insert ordered list command should have succeeded";
EXPECT_EQ("<ol><li>d</li></ol>", document().body()->innerHTML());
}

Powered by Google App Engine
This is Rietveld 408576698