Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Move "common/config" common types into cfgtypes. Move ProjectName and ProjectConfigSet into its own generic package: "luci_config/common/cfgtypes". BUG=chromium:674378 TEST=None Review-Url: https://codereview.chromium.org/2626433004 Committed: https://github.com/luci/luci-go/commit/642108c30d02d7384b5bd960e470a8b4e0ef045b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -317 lines) Patch
D common/config/projectName.go View 1 chunk +0 lines, -66 lines 0 comments Download
D common/config/projectName_test.go View 1 chunk +0 lines, -44 lines 0 comments Download
D common/config/util.go View 1 chunk +0 lines, -14 lines 0 comments Download
M logdog/appengine/coordinator/config/config.go View 4 chunks +5 lines, -4 lines 0 comments Download
M logdog/appengine/coordinator/config/projects.go View 4 chunks +9 lines, -7 lines 0 comments Download
M logdog/appengine/coordinator/context.go View 3 chunks +3 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/context_test.go View 4 chunks +5 lines, -4 lines 0 comments Download
M logdog/appengine/coordinator/coordinatorTest/context.go View 8 chunks +13 lines, -12 lines 0 comments Download
M logdog/appengine/coordinator/coordinatorTest/logStream.go View 3 chunks +3 lines, -3 lines 0 comments Download
M logdog/appengine/coordinator/coordinatorTest/service.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/get.go View 4 chunks +3 lines, -3 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/get_test.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/list_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/query_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/service.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/registration/registerPrefix_test.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/registration/service.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/services/registerStream_test.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/services/service.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/hierarchy/hierarchy.go View 3 chunks +3 lines, -3 lines 0 comments Download
M logdog/appengine/coordinator/hierarchy/hierarchy_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M logdog/appengine/coordinator/hierarchy/project.go View 3 chunks +4 lines, -4 lines 0 comments Download
M logdog/appengine/coordinator/project.go View 5 chunks +7 lines, -6 lines 0 comments Download
M logdog/appengine/coordinator/service.go View 7 chunks +7 lines, -7 lines 0 comments Download
M logdog/client/butler/bootstrap/env.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butler/bundler/bundler.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butler/butler.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butler/output/logdog/output.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butlerlib/bootstrap/bootstrap.go View 3 chunks +3 lines, -3 lines 0 comments Download
M logdog/client/cli/main.go View 3 chunks +4 lines, -4 lines 0 comments Download
M logdog/client/cli/path.go View 1 chunk +2 lines, -2 lines 0 comments Download
M logdog/client/cli/subcommandCat.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/cli/subcommandList.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/cmd/logdog_annotee/link.go View 1 chunk +2 lines, -2 lines 0 comments Download
M logdog/client/cmd/logdog_annotee/main.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/coordinator/client.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/coordinator/list.go View 4 chunks +5 lines, -5 lines 0 comments Download
M logdog/client/coordinator/query.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/coordinator/query_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/coordinator/stream.go View 4 chunks +4 lines, -4 lines 0 comments Download
M logdog/common/storage/archive/storage.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/common/storage/bigtable/cache.go View 4 chunks +4 lines, -4 lines 0 comments Download
M logdog/common/storage/bigtable/logdog_bigtable_test/main.go View 4 chunks +3 lines, -3 lines 0 comments Download
M logdog/common/storage/bigtable/storage.go View 3 chunks +3 lines, -3 lines 0 comments Download
M logdog/common/storage/bigtable/storage_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/common/storage/memory/memory.go View 5 chunks +5 lines, -5 lines 0 comments Download
M logdog/common/storage/memory/memory_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/common/storage/storage.go View 4 chunks +4 lines, -4 lines 0 comments Download
M logdog/common/viewer/url.go View 1 chunk +2 lines, -2 lines 0 comments Download
M logdog/common/viewer/url_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/archivist/archivist.go View 9 chunks +8 lines, -8 lines 0 comments Download
M logdog/server/archivist/archivist_test.go View 4 chunks +3 lines, -3 lines 0 comments Download
M logdog/server/archivist/storageSource.go View 2 chunks +5 lines, -5 lines 0 comments Download
M logdog/server/cmd/logdog_archivist/main.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/collector/collector.go View 4 chunks +3 lines, -3 lines 0 comments Download
M logdog/server/collector/collector_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/collector/coordinator/cache.go View 3 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/collector/coordinator/cache_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/collector/coordinator/coordinator.go View 3 chunks +4 lines, -4 lines 0 comments Download
M logdog/server/collector/utils_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/server/service/config/config.go View 2 chunks +4 lines, -2 lines 0 comments Download
M logdog/server/service/service.go View 3 chunks +2 lines, -2 lines 0 comments Download
A luci_config/common/cfgtypes/config_set.go View 1 chunk +75 lines, -0 lines 0 comments Download
A luci_config/common/cfgtypes/config_set_test.go View 1 chunk +36 lines, -0 lines 0 comments Download
A + luci_config/common/cfgtypes/project_name.go View 1 chunk +1 line, -1 line 0 comments Download
A + luci_config/common/cfgtypes/project_name_test.go View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/logdog/build.go View 4 chunks +3 lines, -3 lines 0 comments Download
M milo/appengine/logdog/http.go View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL. This is NOT a scary CL. Most of the content here is just refactoring. ...
3 years, 11 months ago (2017-01-10 01:33:47 UTC) #2
iannucci
lgtm
3 years, 11 months ago (2017-01-10 19:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626433004/1
3 years, 11 months ago (2017-01-10 19:28:40 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:36:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/642108c30d02d7384b5bd960e470a8b4e0ef045b

Powered by Google App Engine
This is Rietveld 408576698