Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: logdog/appengine/coordinator/context.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/appengine/coordinator/config/projects.go ('k') | logdog/appengine/coordinator/context_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/appengine/coordinator/context.go
diff --git a/logdog/appengine/coordinator/context.go b/logdog/appengine/coordinator/context.go
index 8f061ab7a307930d173f79a56d2fde6bcd2936f6..6b91c1444a6bdd4c157305feb4c1d82a74e86df2 100644
--- a/logdog/appengine/coordinator/context.go
+++ b/logdog/appengine/coordinator/context.go
@@ -13,6 +13,7 @@ import (
"github.com/luci/luci-go/grpc/grpcutil"
"github.com/luci/luci-go/logdog/api/config/svcconfig"
"github.com/luci/luci-go/logdog/appengine/coordinator/config"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
"github.com/luci/luci-go/server/auth"
"github.com/luci/luci-go/server/auth/identity"
@@ -75,7 +76,7 @@ func GetServices(c context.Context) Services {
// - PermissionDenied if the user does not have the requested access.
// - PermissionDenied if the project doesn't exist.
// - Internal if an internal error occurred.
-func WithProjectNamespace(c *context.Context, project luciConfig.ProjectName, at NamespaceAccessType) error {
+func WithProjectNamespace(c *context.Context, project cfgtypes.ProjectName, at NamespaceAccessType) error {
ctx := *c
if err := project.Validate(); err != nil {
@@ -188,7 +189,7 @@ func WithProjectNamespace(c *context.Context, project luciConfig.ProjectName, at
// This function is called with the expectation that the Context is in a
// namespace conforming to ProjectNamespace. If this is not the case, this
// method will panic.
-func Project(c context.Context) luciConfig.ProjectName {
+func Project(c context.Context) cfgtypes.ProjectName {
ns := info.GetNamespace(c)
project := ProjectFromNamespace(ns)
if project != "" {
« no previous file with comments | « logdog/appengine/coordinator/config/projects.go ('k') | logdog/appengine/coordinator/context_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698