Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: logdog/common/storage/bigtable/storage.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/common/storage/bigtable/storage.go
diff --git a/logdog/common/storage/bigtable/storage.go b/logdog/common/storage/bigtable/storage.go
index 1c69879c626c2d2e4a4934016956d50ee3087648..00dd18344fa78a726a4ce2c11a58313563ec4373 100644
--- a/logdog/common/storage/bigtable/storage.go
+++ b/logdog/common/storage/bigtable/storage.go
@@ -9,12 +9,12 @@ import (
"errors"
"fmt"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/common/data/recordio"
log "github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/logdog/common/storage"
"github.com/luci/luci-go/logdog/common/storage/caching"
"github.com/luci/luci-go/logdog/common/types"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
"cloud.google.com/go/bigtable"
"golang.org/x/net/context"
@@ -302,7 +302,7 @@ func (s *btStorage) Get(r storage.GetRequest, cb storage.GetCallback) error {
}
}
-func (s *btStorage) Tail(project config.ProjectName, path types.StreamPath) (*storage.Entry, error) {
+func (s *btStorage) Tail(project cfgtypes.ProjectName, path types.StreamPath) (*storage.Entry, error) {
ctx := log.SetFields(s, log.Fields{
"project": project,
"path": path,
@@ -410,7 +410,7 @@ func (w *rowWriter) append(d []byte) (appended bool) {
}
func (w *rowWriter) flush(ctx context.Context, raw btTable, index types.MessageIndex,
- project config.ProjectName, path types.StreamPath) (int, error) {
+ project cfgtypes.ProjectName, path types.StreamPath) (int, error) {
flushCount := w.count
if flushCount == 0 {
return 0, nil
« no previous file with comments | « logdog/common/storage/bigtable/logdog_bigtable_test/main.go ('k') | logdog/common/storage/bigtable/storage_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698