logdog/appengine/coordinator/endpoints/services/registerStream_test.go - Issue 2626433004: Move "common/config" common types into cfgtypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/appengine/coordinator/endpoints/services/registerStream_test.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « logdog/appengine/coordinator/endpoints/registration/service.go ('k') | logdog/appengine/coordinator/endpoints/services/service.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: logdog/appengine/coordinator/endpoints/services/registerStream_test.go

diff --git a/logdog/appengine/coordinator/endpoints/services/registerStream_test.go b/logdog/appengine/coordinator/endpoints/services/registerStream_test.go

index 1c1b5cef56ab8a06d94b27a85e2523c7ae748fc0..9a373c180f97c53c13dfd08f15d91dbf97a90cc2 100644

--- a/logdog/appengine/coordinator/endpoints/services/registerStream_test.go

+++ b/logdog/appengine/coordinator/endpoints/services/registerStream_test.go

@@ -12,7 +12,6 @@ import (

"github.com/luci/gae/filter/featureBreaker"

ds "github.com/luci/gae/service/datastore"

- "github.com/luci/luci-go/common/config"

"github.com/luci/luci-go/common/proto/google"

"github.com/luci/luci-go/logdog/api/config/svcconfig"

"github.com/luci/luci-go/logdog/api/endpoints/coordinator/services/v1"

@@ -21,6 +20,7 @@ import (

ct "github.com/luci/luci-go/logdog/appengine/coordinator/coordinatorTest"

"github.com/luci/luci-go/logdog/appengine/coordinator/hierarchy"

"github.com/luci/luci-go/logdog/common/types"

+ "github.com/luci/luci-go/luci_config/common/cfgtypes"

"golang.org/x/net/context"

. "github.com/luci/luci-go/common/testing/assertions"

@@ -323,7 +323,7 @@ func BenchmarkRegisterStream(b *testing.B) {

const (

prefix = types.StreamName("testing")

- project = config.ProjectName("proj-foo")

+ project = cfgtypes.ProjectName("proj-foo")

)

tls := ct.MakeStream(c, project, prefix.Join(types.StreamName(fmt.Sprintf("foo/bar"))))