Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: logdog/server/archivist/archivist_test.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/server/archivist/archivist.go ('k') | logdog/server/archivist/storageSource.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/server/archivist/archivist_test.go
diff --git a/logdog/server/archivist/archivist_test.go b/logdog/server/archivist/archivist_test.go
index d2d1bf96449046341094dd74bdb24584eec8a9e8..135eae218edab433ec5a4a0b62975c077b1a2e95 100644
--- a/logdog/server/archivist/archivist_test.go
+++ b/logdog/server/archivist/archivist_test.go
@@ -13,7 +13,6 @@ import (
"github.com/golang/protobuf/proto"
"github.com/luci/luci-go/common/clock/testclock"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/common/errors"
"github.com/luci/luci-go/common/gcloud/gs"
"github.com/luci/luci-go/common/proto/google"
@@ -22,6 +21,7 @@ import (
"github.com/luci/luci-go/logdog/common/storage"
"github.com/luci/luci-go/logdog/common/storage/memory"
"github.com/luci/luci-go/logdog/common/types"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
"golang.org/x/net/context"
"google.golang.org/grpc"
@@ -236,7 +236,7 @@ func TestHandleArchive(t *testing.T) {
}
err = st.Put(storage.PutRequest{
- Project: config.ProjectName(p),
+ Project: cfgtypes.ProjectName(p),
Path: desc.Path(),
Index: types.MessageIndex(v),
Values: [][]byte{d},
@@ -309,7 +309,7 @@ func TestHandleArchive(t *testing.T) {
ar := Archivist{
Service: &sc,
- SettingsLoader: func(c context.Context, proj config.ProjectName) (*Settings, error) {
+ SettingsLoader: func(c context.Context, proj cfgtypes.ProjectName) (*Settings, error) {
// Extra slashes to test concatenation,.
st := stBase
st.GSBase = gs.Path(fmt.Sprintf("gs://archival/%s/path/to/archive/", proj))
« no previous file with comments | « logdog/server/archivist/archivist.go ('k') | logdog/server/archivist/storageSource.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698