Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: logdog/appengine/coordinator/hierarchy/hierarchy_test.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/appengine/coordinator/hierarchy/hierarchy_test.go
diff --git a/logdog/appengine/coordinator/hierarchy/hierarchy_test.go b/logdog/appengine/coordinator/hierarchy/hierarchy_test.go
index 678ff6ab5d721c4eac9a9c3372937b7aac02c74f..28b6909183a2107c200abc3416d5708b4a0857ce 100644
--- a/logdog/appengine/coordinator/hierarchy/hierarchy_test.go
+++ b/logdog/appengine/coordinator/hierarchy/hierarchy_test.go
@@ -10,10 +10,10 @@ import (
ds "github.com/luci/gae/service/datastore"
"github.com/luci/gae/service/info"
- luciConfig "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/logdog/appengine/coordinator"
ct "github.com/luci/luci-go/logdog/appengine/coordinator/coordinatorTest"
"github.com/luci/luci-go/logdog/common/types"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
. "github.com/luci/luci-go/common/testing/assertions"
. "github.com/smartystreets/goconvey/convey"
@@ -151,7 +151,7 @@ func TestHierarchy(t *testing.T) {
})
Convey(`Can register a hierarchy of name components in multiple namespaces.`, func() {
- for _, proj := range []luciConfig.ProjectName{
+ for _, proj := range []cfgtypes.ProjectName{
"proj-foo", "proj-bar", "proj-exclusive",
} {
// Bypass access check.
@@ -187,7 +187,7 @@ func TestHierarchy(t *testing.T) {
Convey(`Can list the hierarchy immediate paths (discrete).`, func() {
r.Project = "proj-foo"
- lv.project = luciConfig.ProjectName(r.Project)
+ lv.project = cfgtypes.ProjectName(r.Project)
list := func(b string) *List {
r.Project = "proj-foo"
@@ -211,7 +211,7 @@ func TestHierarchy(t *testing.T) {
Convey(`Performing discrete queries`, func() {
r.Project = "proj-foo"
- lv.project = luciConfig.ProjectName(r.Project)
+ lv.project = cfgtypes.ProjectName(r.Project)
Convey(`When listing "proj-foo/foo/+"`, func() {
r.PathBase = "foo/+"
@@ -262,7 +262,7 @@ func TestHierarchy(t *testing.T) {
}
type listValidator struct {
- project luciConfig.ProjectName
+ project cfgtypes.ProjectName
pathBase types.StreamPath
}
« no previous file with comments | « logdog/appengine/coordinator/hierarchy/hierarchy.go ('k') | logdog/appengine/coordinator/hierarchy/project.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698