Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: logdog/common/storage/storage.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/common/storage/memory/memory_test.go ('k') | logdog/common/viewer/url.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/common/storage/storage.go
diff --git a/logdog/common/storage/storage.go b/logdog/common/storage/storage.go
index ba09397d1a6504cc4305133cd75e0fa59ab38fea..525396279c6cc1a3a01f8c091ceb09a023379b35 100644
--- a/logdog/common/storage/storage.go
+++ b/logdog/common/storage/storage.go
@@ -8,8 +8,8 @@ import (
"errors"
"time"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/logdog/common/types"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
)
var (
@@ -40,7 +40,7 @@ type Config struct {
// PutRequest describes adding a single storage record to BigTable.
type PutRequest struct {
// Project is the project name of the stream.
- Project config.ProjectName
+ Project cfgtypes.ProjectName
// Path is the stream path to retrieve.
Path types.StreamPath
// Index is the entry's stream index.
@@ -54,7 +54,7 @@ type PutRequest struct {
// GetRequest is a request to retrieve a series of LogEntry records.
type GetRequest struct {
// Project is the project name of the stream.
- Project config.ProjectName
+ Project cfgtypes.ProjectName
// Path is the stream path to retrieve.
Path types.StreamPath
// Index is the entry's stream index.
@@ -117,7 +117,7 @@ type Storage interface {
// The MessageIndex may be -1 if the message index isn't known. In this case,
// the caller will have to unmarshal the log entry data to determine its
// index.
- Tail(config.ProjectName, types.StreamPath) (*Entry, error)
+ Tail(cfgtypes.ProjectName, types.StreamPath) (*Entry, error)
// Config installs the supplied configuration parameters into the storage
// instance.
« no previous file with comments | « logdog/common/storage/memory/memory_test.go ('k') | logdog/common/viewer/url.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698