Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: logdog/client/coordinator/list.go

Issue 2626433004: Move "common/config" common types into cfgtypes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/coordinator/client.go ('k') | logdog/client/coordinator/query.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/coordinator/list.go
diff --git a/logdog/client/coordinator/list.go b/logdog/client/coordinator/list.go
index 9e2fcce767b4f59c74cbcdc18a95612db23dab12..18b02f40a8c6679ccb41b85af3936401d732bc95 100644
--- a/logdog/client/coordinator/list.go
+++ b/logdog/client/coordinator/list.go
@@ -7,16 +7,16 @@ package coordinator
import (
"fmt"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/logdog/api/endpoints/coordinator/logs/v1"
"github.com/luci/luci-go/logdog/common/types"
+ "github.com/luci/luci-go/luci_config/common/cfgtypes"
"golang.org/x/net/context"
)
// ListResult is a single returned list entry.
type ListResult struct {
// Project is the project that this result is bound to.
- Project config.ProjectName
+ Project cfgtypes.ProjectName
// PathBase is the base part of the list path. This will match the base that
// the list was pulled from.
PathBase types.StreamPath
@@ -60,7 +60,7 @@ type ListOptions struct {
// List executes a log stream hierarchy listing for the specified path.
//
// If project is the empty string, a top-level project listing will be returned.
-func (c *Client) List(ctx context.Context, project config.ProjectName, pathBase string, o ListOptions, cb ListCallback) error {
+func (c *Client) List(ctx context.Context, project cfgtypes.ProjectName, pathBase string, o ListOptions, cb ListCallback) error {
req := logdog.ListRequest{
Project: string(project),
PathBase: pathBase,
@@ -77,7 +77,7 @@ func (c *Client) List(ctx context.Context, project config.ProjectName, pathBase
for _, s := range resp.Components {
lr := ListResult{
- Project: config.ProjectName(resp.Project),
+ Project: cfgtypes.ProjectName(resp.Project),
PathBase: types.StreamPath(resp.PathBase),
Name: s.Name,
}
@@ -95,7 +95,7 @@ func (c *Client) List(ctx context.Context, project config.ProjectName, pathBase
}
case logdog.ListResponse_Component_PROJECT:
- lr.Project = config.ProjectName(lr.Name)
+ lr.Project = cfgtypes.ProjectName(lr.Name)
}
if !cb(&lr) {
« no previous file with comments | « logdog/client/coordinator/client.go ('k') | logdog/client/coordinator/query.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698