Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Created:
3 years, 11 months ago by perezju
Modified:
3 years, 11 months ago
Reviewers:
nednguyen, bustamante
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools] Explicit timeout keyword in WaitForJavaScriptCondition Explicitly use the timeout_in_seconds keyword argument in action_runner.WaitForJavaScriptCondition; this is to allow an API change in the signature of that method. TBR=bustamante@chromium.org BUG=catapult:#3028 Review-Url: https://codereview.chromium.org/2617483006 Cr-Commit-Position: refs/heads/master@{#442238} Committed: https://chromium.googlesource.com/chromium/src/+/027bfe2aaf9b681c4c484ff411211591101247c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/blob_workshop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/indexeddb_endure_page.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/repaint_helpers.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
perezju
bustamante: tools/chrome_proxy/* - 1 file nednguyen: tools/perf/*
3 years, 11 months ago (2017-01-06 14:58:28 UTC) #4
nednguyen
lgtm
3 years, 11 months ago (2017-01-06 15:16:40 UTC) #5
perezju
TBR'ing bustamante as this is only a tiny change and is blocking other CLs.
3 years, 11 months ago (2017-01-09 11:22:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617483006/1
3 years, 11 months ago (2017-01-09 11:23:05 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 12:26:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/027bfe2aaf9b681c4c484ff41121...

Powered by Google App Engine
This is Rietveld 408576698