Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: tools/perf/page_sets/repaint_helpers.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/maps.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import legacy_page_test 5 from telemetry.page import legacy_page_test
6 6
7 7
8 def Repaint(action_runner, mode='viewport', width=None, height=None): 8 def Repaint(action_runner, mode='viewport', width=None, height=None):
9 action_runner.WaitForJavaScriptCondition( 9 action_runner.WaitForJavaScriptCondition(
10 'document.readyState == "complete"', 90) 10 'document.readyState == "complete"', timeout_in_seconds=90)
11 # Rasterize only what's visible. 11 # Rasterize only what's visible.
12 action_runner.ExecuteJavaScript( 12 action_runner.ExecuteJavaScript(
13 'chrome.gpuBenchmarking.setRasterizeOnlyVisibleContent();') 13 'chrome.gpuBenchmarking.setRasterizeOnlyVisibleContent();')
14 14
15 args = {} 15 args = {}
16 args['mode'] = mode 16 args['mode'] = mode
17 if width: 17 if width:
18 args['width'] = width 18 args['width'] = width
19 if height: 19 if height:
20 args['height'] = height 20 args['height'] = height
(...skipping 24 matching lines...) Expand all
45 chrome.gpuBenchmarking.sendMessageToMicroBenchmark( 45 chrome.gpuBenchmarking.sendMessageToMicroBenchmark(
46 """ + str(micro_benchmark_id) + """, { 46 """ + str(micro_benchmark_id) + """, {
47 "notify_done": true 47 "notify_done": true
48 }); 48 });
49 """) 49 """)
50 50
51 51
52 def WaitThenRepaint(action_runner): 52 def WaitThenRepaint(action_runner):
53 action_runner.Wait(2) 53 action_runner.Wait(2)
54 Repaint(action_runner) 54 Repaint(action_runner)
OLDNEW
« no previous file with comments | « tools/perf/page_sets/maps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698