tools/perf/page_sets/maps.py - Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/maps.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/maps.py

diff --git a/tools/perf/page_sets/maps.py b/tools/perf/page_sets/maps.py

index b535d205f217564dd116c2a49c4de939e8df230a..373bb7a3a3f2f6afef709f377aa509c077852b48 100644

--- a/tools/perf/page_sets/maps.py

+++ b/tools/perf/page_sets/maps.py

@@ -30,7 +30,7 @@ class MapsPage(page_module.Page):

def RunPageInteractions(self, action_runner):

with action_runner.CreateInteraction('MapAnimation'):

action_runner.WaitForJavaScriptCondition(

- 'window.testMetrics != undefined', 120)

+ 'window.testMetrics != undefined', timeout_in_seconds=120)

class MapsPageSet(story.StorySet):