Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: tools/perf/page_sets/maps.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_smooth.py ('k') | tools/perf/page_sets/repaint_helpers.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/maps.py
diff --git a/tools/perf/page_sets/maps.py b/tools/perf/page_sets/maps.py
index b535d205f217564dd116c2a49c4de939e8df230a..373bb7a3a3f2f6afef709f377aa509c077852b48 100644
--- a/tools/perf/page_sets/maps.py
+++ b/tools/perf/page_sets/maps.py
@@ -30,7 +30,7 @@ class MapsPage(page_module.Page):
def RunPageInteractions(self, action_runner):
with action_runner.CreateInteraction('MapAnimation'):
action_runner.WaitForJavaScriptCondition(
- 'window.testMetrics != undefined', 120)
+ 'window.testMetrics != undefined', timeout_in_seconds=120)
class MapsPageSet(story.StorySet):
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_smooth.py ('k') | tools/perf/page_sets/repaint_helpers.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698