tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py - Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

index 2be562185918176fb620e29d585378183a444085..30def6634575f1f5f8837f5c8f7673fea26a7597 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

@@ -36,7 +36,7 @@ class BlockOncePage(page_module.Page):

})();

''')

action_runner.WaitForJavaScriptCondition(

- "window.post_request_completed == true", 30)

+ "window.post_request_completed == true", timeout_in_seconds=30)

class BlockOnceStorySet(story.StorySet):

« no previous file with comments | « no previous file | tools/perf/page_sets/blob_workshop.py » ('j') | no next file with comments »