tools/perf/page_sets/repaint_helpers.py - Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/repaint_helpers.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/repaint_helpers.py

diff --git a/tools/perf/page_sets/repaint_helpers.py b/tools/perf/page_sets/repaint_helpers.py

index 93f2b9e1d08b5b599721cabe81342d7ca000f8b0..08bd48f0d75473bcb146ab7a0fe6a743231171b1 100644

--- a/tools/perf/page_sets/repaint_helpers.py

+++ b/tools/perf/page_sets/repaint_helpers.py

@@ -7,7 +7,7 @@ from telemetry.page import legacy_page_test

def Repaint(action_runner, mode='viewport', width=None, height=None):

action_runner.WaitForJavaScriptCondition(

- 'document.readyState == "complete"', 90)

+ 'document.readyState == "complete"', timeout_in_seconds=90)

# Rasterize only what's visible.

action_runner.ExecuteJavaScript(

'chrome.gpuBenchmarking.setRasterizeOnlyVisibleContent();')

« no previous file with comments | « tools/perf/page_sets/maps.py ('k') | no next file » | no next file with comments »