tools/perf/page_sets/key_mobile_sites_smooth.py - Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_mobile_sites_smooth.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/key_mobile_sites_smooth.py

diff --git a/tools/perf/page_sets/key_mobile_sites_smooth.py b/tools/perf/page_sets/key_mobile_sites_smooth.py

index 325782b27c76765aa9967e84d65dbe8684907f15..0a6c669d756137c0c35462bb874bcaee081c7774 100644

--- a/tools/perf/page_sets/key_mobile_sites_smooth.py

+++ b/tools/perf/page_sets/key_mobile_sites_smooth.py

@@ -35,7 +35,7 @@ class KeyMobileSitesSmoothPage(page_module.Page):

def RunPageInteractions(self, action_runner):

if self.action_on_load_complete:

action_runner.WaitForJavaScriptCondition(

- 'document.readyState == "complete"', 30)

+ 'document.readyState == "complete"', timeout_in_seconds=30)

_IssueMarkerAndScroll(action_runner)

« no previous file with comments | « tools/perf/page_sets/indexeddb_endure_page.py ('k') | tools/perf/page_sets/maps.py » ('j') | no next file with comments »