tools/perf/page_sets/indexeddb_endure_page.py - Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/indexeddb_endure_page.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/indexeddb_endure_page.py

diff --git a/tools/perf/page_sets/indexeddb_endure_page.py b/tools/perf/page_sets/indexeddb_endure_page.py

index eff676c223a20870e49aabc6003da47a9307568f..ada21bec28ac373c3e23db641a09d179a3dd83e8 100644

--- a/tools/perf/page_sets/indexeddb_endure_page.py

+++ b/tools/perf/page_sets/indexeddb_endure_page.py

@@ -20,7 +20,8 @@ class IndexedDBEndurePage(page_module.Page):

self._subtest + '";')

with action_runner.CreateInteraction('Action_Test'):

action_runner.ExecuteJavaScript('window.test();')

- action_runner.WaitForJavaScriptCondition('window.done', 600)

+ action_runner.WaitForJavaScriptCondition(

+ 'window.done', timeout_in_seconds=600)

class IndexedDBEndurePageSet(story.StorySet):

"""The IndexedDB Endurance page set.