Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: tools/perf/page_sets/blob_workshop.py

Issue 2617483006: [tools] Explicit timeout keyword in WaitForJavaScriptCondition (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/blob_workshop.py
diff --git a/tools/perf/page_sets/blob_workshop.py b/tools/perf/page_sets/blob_workshop.py
index 9778b3139ace9190b4441c032a1562e3ea71e3fe..a766293f9d3d731a88ddf42215b011da52769660 100644
--- a/tools/perf/page_sets/blob_workshop.py
+++ b/tools/perf/page_sets/blob_workshop.py
@@ -29,7 +29,7 @@ class BlobCreateThenRead(page_module.Page):
action_runner.ExecuteJavaScript(
'createAndRead(' + str(size_bytes) + ');')
action_runner.WaitForJavaScriptCondition(
- 'doneReading === true || errors', 60)
+ 'doneReading === true || errors', timeout_in_seconds=60)
errors = action_runner.EvaluateJavaScript('errors')
if errors:
@@ -60,7 +60,7 @@ class BlobMassCreate(page_module.Page):
repeatable=True):
action_runner.ExecuteJavaScript('readBlobsSerially();')
action_runner.WaitForJavaScriptCondition(
- 'doneReading === true || errors', 60)
+ 'doneReading === true || errors', timeout_in_seconds=60)
# Clean up blobs. Make sure this flag is turned on:
# --enable-experimental-web-platform-features
action_runner.ExecuteJavaScript('garbageCollect();')

Powered by Google App Engine
This is Rietveld 408576698