Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, Eric Willigers, f(malita), hongchan, iclelland, jbroman, Justin Novosad, kinuko+fileapi, kinuko+watch, kouhei+heap_chromium.org, leviw+bidiwatch_chromium.org, lunalu1, mcasas+watch+mediastream_chromium.org, nhiroki, oilpan-reviews, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rjwright, rwlbuis, Raymond Toy, Stephen Chennney, shans, tommyw+watchlist_chromium.org, tzik, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 14 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/platform/. There are too many references to change them all at once, so this CL is part 14 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2615813003 Cr-Commit-Position: refs/heads/master@{#441969} Committed: https://chromium.googlesource.com/chromium/src/+/dd927e05ce64314bec330c5ad7b744625c5ab181

Patch Set 1 #

Patch Set 2 : rebase, small fix in FontSettings.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -512 lines) Patch
M third_party/WebKit/Source/platform/ContextMenu.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/FileChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Language.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/PODArena.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODFreeListArenaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODIntervalTree.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODIntervalTreeTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/PODRedBlackTreeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/WebIconSizesParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/WebVectorTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioBus.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioResampler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/Reverb.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.cpp View 7 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FallbackListCompositeKey.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDescriptionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/GlyphBuffer.h View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SegmentedFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SmallCapsIteratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/opentype/FontSettings.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 9 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/Region.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PathTraversalState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ProfilingCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 39 chunks +108 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/json/JSONValues.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/json/JSONValues.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/EncodedFormData.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/network/FormDataEncoder.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 8 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/network/LinkHeader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/plugins/PluginData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ArenaTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/PictureMatchers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp View 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/text/Hyphenation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICU.cpp View 6 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICUTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/QuotedPrintable.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/InterpolatedTransformOperation.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformOperations.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformOperationsTest.cpp View 16 chunks +41 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
pilgrim_google
3 years, 11 months ago (2017-01-05 21:52:15 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-05 23:10:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615813003/20001
3 years, 11 months ago (2017-01-06 14:33:46 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 17:49:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd927e05ce64314bec330c5ad7b7...

Powered by Google App Engine
This is Rietveld 408576698