third_party/WebKit/Source/platform/json/JSONValues.h - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/json/JSONValues.h

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/json/JSONValues.h

diff --git a/third_party/WebKit/Source/platform/json/JSONValues.h b/third_party/WebKit/Source/platform/json/JSONValues.h

index b179d6e66dbbd847ccf88a910d33c3c96440a3ee..4a37cd7913cff7254aa28ade9b781bf7856ca8c2 100644

--- a/third_party/WebKit/Source/platform/json/JSONValues.h

+++ b/third_party/WebKit/Source/platform/json/JSONValues.h

@@ -226,7 +226,7 @@ class PLATFORM_EXPORT JSONObject : public JSONValue {

void set(const String& key, std::unique_ptr<T>& value) {

DCHECK(value);

if (m_data.set(key, std::move(value)).isNewEntry)

- m_order.append(key);

+ m_order.push_back(key);

}

using Dictionary = HashMap<String, std::unique_ptr<JSONValue>>;