third_party/WebKit/Source/platform/network/ResourceResponse.cpp - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/ResourceResponse.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/network/LinkHeader.cpp ('k') | third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/ResourceResponse.cpp

diff --git a/third_party/WebKit/Source/platform/network/ResourceResponse.cpp b/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

index c01a39e03a1ff399f5828a77b75a4acd4dfdcd21..9f58f33c3cc72104f6c3c2099cecbf10ed7335ae 100644

--- a/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

+++ b/third_party/WebKit/Source/platform/network/ResourceResponse.cpp

@@ -40,7 +40,7 @@ Vector<Interface> isolatedCopy(const Vector<Interface>& src) {

Vector<Interface> result;

result.reserveCapacity(src.size());

for (const auto& timestamp : src) {

- result.append(timestamp.isolatedCopy());

+ result.push_back(timestamp.isolatedCopy());

}

return result;

}

@@ -170,7 +170,7 @@ ResourceResponse::ResourceResponse(CrossThreadResourceResponseData* data)

m_securityDetails.validFrom = data->m_securityDetails.validFrom;

m_securityDetails.validTo = data->m_securityDetails.validTo;

for (auto& cert : data->m_certificate)

- m_securityDetails.certificate.append(AtomicString(cert));

+ m_securityDetails.certificate.push_back(AtomicString(cert));

m_securityDetails.sctList = data->m_securityDetails.sctList;

m_httpVersion = data->m_httpVersion;

m_appCacheID = data->m_appCacheID;

@@ -235,7 +235,7 @@ std::unique_ptr<CrossThreadResourceResponseData> ResourceResponse::copyData()

data->m_securityDetails.validFrom = m_securityDetails.validFrom;

data->m_securityDetails.validTo = m_securityDetails.validTo;

for (auto& cert : m_securityDetails.certificate)

- data->m_certificate.append(cert.getString().isolatedCopy());

+ data->m_certificate.push_back(cert.getString().isolatedCopy());

data->m_securityDetails.sctList = isolatedCopy(m_securityDetails.sctList);

data->m_httpVersion = m_httpVersion;

data->m_appCacheID = m_appCacheID;

@@ -636,7 +636,7 @@ void ResourceResponse::setDownloadedFilePath(const String& downloadedFilePath) {

void ResourceResponse::appendRedirectResponse(

const ResourceResponse& response) {

- m_redirectResponses.append(response);

+ m_redirectResponses.push_back(response);

}

bool ResourceResponse::compare(const ResourceResponse& a,