third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/opentype/FontSettings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp b/third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp

index f7fa78c16b5fa4ec4423fa42c4f07db2dd0c3b0e..75d41a50a42eb425832abf132a094e74ea9c6efd 100644

--- a/third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp

@@ -22,7 +22,7 @@ TEST(UnicodeRangeSet, Empty) {

TEST(UnicodeRangeSet, SingleCharacter) {

Vector<UnicodeRange> ranges;

- ranges.append(UnicodeRange('b', 'b'));

+ ranges.push_back(UnicodeRange('b', 'b'));

RefPtr<UnicodeRangeSet> set = adoptRef(new UnicodeRangeSet(ranges));

EXPECT_FALSE(set->isEntireRange());

EXPECT_FALSE(set->intersectsWith(String()));

@@ -38,8 +38,8 @@ TEST(UnicodeRangeSet, SingleCharacter) {

TEST(UnicodeRangeSet, TwoRanges) {

Vector<UnicodeRange> ranges;

- ranges.append(UnicodeRange('6', '7'));

- ranges.append(UnicodeRange('2', '4'));

+ ranges.push_back(UnicodeRange('6', '7'));

+ ranges.push_back(UnicodeRange('2', '4'));

RefPtr<UnicodeRangeSet> set = adoptRef(new UnicodeRangeSet(ranges));

EXPECT_FALSE(set->isEntireRange());

EXPECT_FALSE(set->intersectsWith(String()));

@@ -60,10 +60,10 @@ TEST(UnicodeRangeSet, TwoRanges) {

TEST(UnicodeRangeSet, Overlap) {

Vector<UnicodeRange> ranges;

- ranges.append(UnicodeRange('0', '2'));

- ranges.append(UnicodeRange('1', '1'));

- ranges.append(UnicodeRange('3', '5'));

- ranges.append(UnicodeRange('4', '6'));

+ ranges.push_back(UnicodeRange('0', '2'));

+ ranges.push_back(UnicodeRange('1', '1'));

+ ranges.push_back(UnicodeRange('3', '5'));

+ ranges.push_back(UnicodeRange('4', '6'));

RefPtr<UnicodeRangeSet> set = adoptRef(new UnicodeRangeSet(ranges));

ASSERT_EQ(1u, set->size());

EXPECT_EQ('0', set->rangeAt(0).from());

@@ -72,7 +72,7 @@ TEST(UnicodeRangeSet, Overlap) {

TEST(UnicodeRangeSet, Non8Bit) {

Vector<UnicodeRange> ranges;

- ranges.append(UnicodeRange(0x3042, 0x3042));

+ ranges.push_back(UnicodeRange(0x3042, 0x3042));

RefPtr<UnicodeRangeSet> set = adoptRef(new UnicodeRangeSet(ranges));

ASSERT_EQ(1u, set->size());

EXPECT_EQ(0x3042, set->rangeAt(0).from());