third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

index 93fb0e6111da31a34b22f47e1346e60d3a047676..833057dba30108a9914bb59738150a71826ed970 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

@@ -49,9 +49,9 @@ class RunSegmenterTest : public testing::Test {

for (auto& run : runs) {

unsigned lengthBefore = text.length();

text.append(String::fromUTF8(run.text.c_str()));

- expect.append(SegmenterExpectedRun(lengthBefore, text.length(),

- run.script, run.renderOrientation,

- run.fontFallbackPriority));

+ expect.push_back(SegmenterExpectedRun(lengthBefore, text.length(),

+ run.script, run.renderOrientation,

+ run.fontFallbackPriority));

}

RunSegmenter runSegmenter(text.characters16(), text.length(), orientation);

VerifyRuns(&runSegmenter, expect);