third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp - Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)

Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/opentype/FontSettings.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2015 Google Inc. All rights reserved.	2 * Copyright (C) 2015 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 122 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
133 const TextRun& run) {	133 const TextRun& run) {

134 ShapeResultBuffer buffer;	134 ShapeResultBuffer buffer;

135 float totalWidth =	135 float totalWidth =

136 shapeResultsForRun(m_shapeCache, font, run, nullptr, &buffer);	136 shapeResultsForRun(m_shapeCache, font, run, nullptr, &buffer);

137	137

138 auto ranges = buffer.individualCharacterRanges(run.direction(), totalWidth);	138 auto ranges = buffer.individualCharacterRanges(run.direction(), totalWidth);

139 // The shaper can fail to return glyph metrics for all characters (see	139 // The shaper can fail to return glyph metrics for all characters (see

140 // crbug.com/613915 and crbug.com/615661) so add empty ranges to ensure all	140 // crbug.com/613915 and crbug.com/615661) so add empty ranges to ensure all

141 // characters have an associated range.	141 // characters have an associated range.

142 while (ranges.size() < static_cast<unsigned>(run.length()))	142 while (ranges.size() < static_cast<unsigned>(run.length()))

143 ranges.append(CharacterRange(0, 0));	143 ranges.push_back(CharacterRange(0, 0));

144 return ranges;	144 return ranges;

145 }	145 }

146	146

147 }; // namespace blink	147 }; // namespace blink

OLD	NEW